Fix iOS pinch-to-zoom initialization by listening to loadeddata event #887
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS Safari, the
<video>element often reportsvideoWidth/videoHeightas0when onlyloadedmetadatahas fired. This causesDigitalPTZ.updateRects()to bail early, leavingthis.videoRectunset and breaking pinch-to-zoom until a later navigation or redraw.This PR adds an additional listener for the
loadeddataevent, which reliably fires once the first frame is available and dimensions are known. With this change,this.videoRectis correctly initialized on iOS and pinch-to-zoom works immediately.Changes
videoEl.addEventListener("loadeddata", this.recomputeRects);inDigitalPTZconstructorthis.videoRectis set when the video dimensions are first available on iOS