Fix memory leaks in HLS sessions, WriteBuffer, and RTSP UDP handling #1979
+160
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add MaxSessions limit (100) to prevent HLS session accumulation - Add session cleanup goroutine with 30-second monitoring interval - Add MaxBufferSize (16MB) limit to HLS session buffers - Add MaxWriteBufferSize (8MB) limit to WriteBuffer - Add sync.Pool for UDP read buffers in RTSP conn to reduce allocations - Add debug logging for session creation/expiration These fixes address memory growth issues observed during extended operation where go2rtc memory would grow from ~150MB to 7GB+ over 2.5 days.
- Add createdAt timestamp to Session struct - Add MaxSessionAge constant (24 hours) for session lifetime limit - Update sessionCleanup to identify and remove sessions older than MaxSessionAge - Stop alive timer when cleaning up stale sessions to prevent double cleanup - Log removed stale sessions with their age for debugging
Owner
Using this doesn't make any sense at all. Because you're allocating new memory for every new packet anyway. PS. It's better to organize these things into different PR. Because they're completely different. |
Owner
It's quite rare that And truncating the data is a bad solution. For many formats, it will completely break streaming. And sending the data further makes no sense. |
Author
|
Thanks for your feedback, I will try a different approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes address memory growth issues observed during extended operation where go2rtc memory would grow from ~150MB to 7GB+ over 2.5 days with usage from lightNVR.