Support TURN REST API (Shared Secret) Authentication#2073
Open
lowlyocean wants to merge 1 commit intoAlexxIT:masterfrom
Open
Support TURN REST API (Shared Secret) Authentication#2073lowlyocean wants to merge 1 commit intoAlexxIT:masterfrom
lowlyocean wants to merge 1 commit intoAlexxIT:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #500
Pion's turn/v4 library (already an indirect dependency) provides GenerateLongTermTURNRESTCredentials() which generates time-limited HMAC-SHA1 credentials from a shared secret — exactly what coturn expects.
3 files with minimal changes:
webrtc.go: custom ICEServerConfig struct with shared_secret and credential_ttl fields, a resolveICEServers() function that generates fresh credentials per connection, and moving config resolution into the PeerConnection closurego.mod: promote pion/turn/v4 to direct dependencyschema.json: add the new fields to the JSON schemaUsage: