Skip to content

AAE-42151 [FE - Studio Admin] Improve types for Integration Contexts#11633

Merged
tomson7777 merged 3 commits intodevelopfrom
fix/AAE-42151-update-integration-context-types
Feb 11, 2026
Merged

AAE-42151 [FE - Studio Admin] Improve types for Integration Contexts#11633
tomson7777 merged 3 commits intodevelopfrom
fix/AAE-42151-update-integration-context-types

Conversation

@tomson7777
Copy link
Contributor

@tomson7777 tomson7777 commented Feb 10, 2026

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Wrong types

What is the new behaviour?
Correct types

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

Added
13 new fields to ServiceTaskIntegrationContextCloudModel: serviceType, parentProcessInstanceId, rootProcessInstanceId, connectorType, clientId, clientName, clientType, businessKey, inBoundVariables, outBoundVariables, requestDate, resultDate, stackTraceElements
ServiceTaskStackTraceElement interface (classLoaderName, moduleName, moduleVersion, methodName, fileName, lineNumber, className, nativeMethod)
Type-safe generic on this.get() (removed any)

Removed
extends ServiceTaskQueryCloudRequestModel from ServiceTaskIntegrationContextCloudModel
9 irrelevant query parameter fields: environmentId, maxItems, skipCount, sorting, activityName, activityType, completedDate, elementId, startedDate

@dsibilio dsibilio requested a review from Copilot February 10, 2026 12:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves type safety for Service Task Integration Context retrieval by tightening the HTTP response typing and expanding the ServiceTaskIntegrationContextCloudModel to better reflect the API payload.

Changes:

  • Added a typed generic to this.get() to avoid any in getServiceTaskStatus.
  • Reworked ServiceTaskIntegrationContextCloudModel to remove query-related fields and add integration-context-specific fields.
  • Introduced ServiceTaskStackTraceElement for typed stack trace payloads.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
lib/process-services-cloud/src/lib/task/task-list/services/service-task-list-cloud.service.ts Adds a typed generic for the integration-context API response and returns the typed entry.
lib/process-services-cloud/src/lib/task/task-list/models/service-task-cloud.model.ts Redefines the integration context model with additional typed fields and adds a stack trace element interface.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI commented Feb 10, 2026

@tomson7777 I've opened a new pull request, #11636, to work on those changes. Once the pull request is ready, I'll request review from you.

@sonarqubecloud
Copy link

@tomson7777 tomson7777 merged commit 30afd2d into develop Feb 11, 2026
19 checks passed
@tomson7777 tomson7777 deleted the fix/AAE-42151-update-integration-context-types branch February 11, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants