AAE-42658 Remove check for outcome.id as name based outcomes are valid#11685
Merged
ehilgendorf merged 1 commit intodevelopfrom Feb 25, 2026
Merged
AAE-42658 Remove check for outcome.id as name based outcomes are valid#11685ehilgendorf merged 1 commit intodevelopfrom
ehilgendorf merged 1 commit intodevelopfrom
Conversation
ehilgendorf
requested review from
DenysVuika and
popovicsandras
as code owners
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes an overly restrictive check in the form outcome handling logic. Previously, the code required both outcome.name AND outcome.id to be present for custom (non-system) outcomes. However, according to the existing code comment, Activiti uses the NAME field as the primary identifier for outcomes, making the id check unnecessary and preventing valid name-based outcomes from being processed.
Changes:
- Removed the
outcome.idcheck from the conditional inform-base.component.ts, allowing outcomes with only a name (and null id) to be processed - Added comprehensive test coverage for the new behavior in both process-services and process-services-cloud components
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/core/src/lib/form/components/form-base.component.ts | Removed outcome.id check from conditional, allowing name-only outcomes to complete forms |
| lib/process-services/src/lib/form/form.component.spec.ts | Added test verifying forms can be completed with outcomes that have null id but valid name |
| lib/process-services-cloud/src/lib/form/components/form-cloud.component.spec.ts | Added identical test for cloud component to ensure consistent behavior across implementations |
MichalKinas
approved these changes
Feb 24, 2026
DenysVuika
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/AAE-42658
What is the new behaviour?
The removed check is not needed at this place
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: