AAE-42804 Cleaning up tasks and process filter components#11693
Merged
ehsan-2019 merged 3 commits intodevelopfrom Feb 26, 2026
Merged
AAE-42804 Cleaning up tasks and process filter components#11693ehsan-2019 merged 3 commits intodevelopfrom
ehsan-2019 merged 3 commits intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the task and process filter components to use modern Angular patterns, including migration from structural directives to built-in control flow syntax, replacing mat-action-list with mat-nav-list for better navigation semantics, and adopting Material Design 3 theming tokens.
Changes:
- Migrated from
*ngIf/*ngForstructural directives to@if/@for` built-in control flow syntax - Replaced
mat-action-listwithmat-nav-listand integrated Angular router for filter navigation - Updated SCSS to use Material Design 3 tokens with fallbacks to legacy theme variables
- Removed
ViewEncapsulation.Nonefrom component decorators - Simplified tests to focus on router navigation behavior instead of CSS class manipulation
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| task-filters-cloud.component.ts | Added router integration with signals and query params; removed ViewEncapsulation |
| task-filters-cloud.component.html | Migrated to modern control flow syntax and mat-nav-list with router links |
| task-filters-cloud.component.scss | Updated to use Material Design 3 tokens with fallbacks |
| task-filters-cloud.component.spec.ts | Simplified tests to verify router navigation instead of CSS classes |
| process-filters-cloud.component.ts | Added router integration with signals and query params; removed ViewEncapsulation |
| process-filters-cloud.component.html | Migrated to modern control flow syntax and mat-nav-list with router links |
| process-filters-cloud.component.scss | Updated to use Material Design 3 tokens with fallbacks |
| process-filters-cloud.component.spec.ts | Simplified tests and fixed typo; verified router navigation |
...es-cloud/src/lib/task/task-filters/components/task-filters/task-filters-cloud.component.html
Outdated
Show resolved
Hide resolved
...es-cloud/src/lib/task/task-filters/components/task-filters/task-filters-cloud.component.html
Outdated
Show resolved
Hide resolved
.../lib/process/process-filters/components/process-filters/process-filters-cloud.component.html
Outdated
Show resolved
Hide resolved
...rc/lib/process/process-filters/components/process-filters/process-filters-cloud.component.ts
Show resolved
Hide resolved
.../lib/process/process-filters/components/process-filters/process-filters-cloud.component.html
Outdated
Show resolved
Hide resolved
.../lib/process/process-filters/components/process-filters/process-filters-cloud.component.html
Show resolved
Hide resolved
...es-cloud/src/lib/task/task-filters/components/task-filters/task-filters-cloud.component.html
Outdated
Show resolved
Hide resolved
.../lib/process/process-filters/components/process-filters/process-filters-cloud.component.html
Outdated
Show resolved
Hide resolved
40ee295 to
cd7d905
Compare
|
DenysVuika
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
AAE-42804
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: