Skip to content

AAE-42804 Cleaning up tasks and process filter components#11693

Merged
ehsan-2019 merged 3 commits intodevelopfrom
improvement/AAE-42804-clean-up-tasks-filter-component
Feb 26, 2026
Merged

AAE-42804 Cleaning up tasks and process filter components#11693
ehsan-2019 merged 3 commits intodevelopfrom
improvement/AAE-42804-clean-up-tasks-filter-component

Conversation

@ehsan-2019
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

AAE-42804

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@ehsan-2019 ehsan-2019 requested a review from eromano as a code owner February 26, 2026 15:08
Copilot AI review requested due to automatic review settings February 26, 2026 15:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the task and process filter components to use modern Angular patterns, including migration from structural directives to built-in control flow syntax, replacing mat-action-list with mat-nav-list for better navigation semantics, and adopting Material Design 3 theming tokens.

Changes:

  • Migrated from *ngIf/*ngFor structural directives to @if/@for` built-in control flow syntax
  • Replaced mat-action-list with mat-nav-list and integrated Angular router for filter navigation
  • Updated SCSS to use Material Design 3 tokens with fallbacks to legacy theme variables
  • Removed ViewEncapsulation.None from component decorators
  • Simplified tests to focus on router navigation behavior instead of CSS class manipulation

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
task-filters-cloud.component.ts Added router integration with signals and query params; removed ViewEncapsulation
task-filters-cloud.component.html Migrated to modern control flow syntax and mat-nav-list with router links
task-filters-cloud.component.scss Updated to use Material Design 3 tokens with fallbacks
task-filters-cloud.component.spec.ts Simplified tests to verify router navigation instead of CSS classes
process-filters-cloud.component.ts Added router integration with signals and query params; removed ViewEncapsulation
process-filters-cloud.component.html Migrated to modern control flow syntax and mat-nav-list with router links
process-filters-cloud.component.scss Updated to use Material Design 3 tokens with fallbacks
process-filters-cloud.component.spec.ts Simplified tests and fixed typo; verified router navigation

@ehsan-2019 ehsan-2019 force-pushed the improvement/AAE-42804-clean-up-tasks-filter-component branch from 40ee295 to cd7d905 Compare February 26, 2026 15:53
@sonarqubecloud
Copy link

@ehsan-2019 ehsan-2019 enabled auto-merge (squash) February 26, 2026 16:11
@ehsan-2019 ehsan-2019 merged commit dd66ecc into develop Feb 26, 2026
26 of 28 checks passed
@ehsan-2019 ehsan-2019 deleted the improvement/AAE-42804-clean-up-tasks-filter-component branch February 26, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants