[ACS-11213] Updated ngx translate in libs#11699
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR updates the @ngx-translate/core dependency from versions 14.0.0 and 16.0.0 to 17.0.0 across five ADF library packages. The update aligns these library peer dependencies with the root package.json, which already uses @ngx-translate/core ^17.0.0. This is a refactoring change that standardizes the ngx-translate version across all ADF libraries.
Changes:
- Updated
@ngx-translate/corefrom >=14.0.0 to >=17.0.0 in three libraries (process-services, process-services-cloud, insights) - Updated
@ngx-translate/corefrom >=16.0.0 to >=17.0.0 in two libraries (core, content-services)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/process-services/package.json | Updated @ngx-translate/core peer dependency from >=14.0.0 to >=17.0.0 |
| lib/process-services-cloud/package.json | Updated @ngx-translate/core peer dependency from >=14.0.0 to >=17.0.0 |
| lib/insights/package.json | Updated @ngx-translate/core direct dependency from >=14.0.0 to >=17.0.0 |
| lib/core/package.json | Updated @ngx-translate/core peer dependency from >=16.0.0 to >=17.0.0 |
| lib/content-services/package.json | Updated @ngx-translate/core peer dependency from >=16.0.0 to >=17.0.0 |
| "@angular/router": ">=14.1.3", | ||
| "@alfresco/js-api": ">=9.2.1", | ||
| "@ngx-translate/core": ">=16.0.0", | ||
| "@ngx-translate/core": ">=17.0.0", |
There was a problem hiding this comment.
The update to @ngx-translate/core >=17.0.0 may be incompatible with the stated Angular peer dependency of >=14.1.3. The @ngx-translate/core v17 requires Angular 17 or higher. This could cause issues for consumers using Angular versions 14-16 with this library. Consider either:
- Updating the Angular peer dependencies to >=17.0.0 to reflect the actual compatibility requirements, or
- Verifying that
@ngx-translate/core17 actually works with Angular 14+ and documenting this if needed.
The same issue applies to lib/process-services/package.json and lib/process-services-cloud/package.json which also specify Angular >=14.1.3.
| "@alfresco/adf-core": ">=8.2.1", | ||
| "@alfresco/adf-content-services": ">=8.2.1", | ||
| "@ngx-translate/core": ">=14.0.0" | ||
| "@ngx-translate/core": ">=17.0.0" |
There was a problem hiding this comment.
The update to @ngx-translate/core >=17.0.0 may be incompatible with the stated Angular peer dependency of >=14.1.3. The @ngx-translate/core v17 requires Angular 17 or higher. This could cause issues for consumers using Angular versions 14-16 with this library. Consider updating the Angular peer dependencies to >=17.0.0 to reflect the actual compatibility requirements.
| "@alfresco/adf-content-services": ">=8.2.1", | ||
| "@apollo/client": ">=3.7.2", | ||
| "@ngx-translate/core": ">=14.0.0", | ||
| "@ngx-translate/core": ">=17.0.0", |
There was a problem hiding this comment.
The update to @ngx-translate/core >=17.0.0 may be incompatible with the stated Angular peer dependency of >=14.1.3. The @ngx-translate/core v17 requires Angular 17 or higher. This could cause issues for consumers using Angular versions 14-16 with this library. Consider updating the Angular peer dependencies to >=17.0.0 to reflect the actual compatibility requirements.
| "@angular/router": ">=16.0.0", | ||
| "@mat-datetimepicker/core": ">=12.0.1", | ||
| "@ngx-translate/core": ">=16.0.0", | ||
| "@ngx-translate/core": ">=17.0.0", |
There was a problem hiding this comment.
The update to @ngx-translate/core >=17.0.0 may be incompatible with the stated Angular peer dependency of >=16.0.0. The @ngx-translate/core v17 requires Angular 17 or higher. This could cause issues for consumers using Angular 16 with this library. Consider updating the Angular peer dependencies to >=17.0.0 to reflect the actual compatibility requirements.
| "@alfresco/adf-core": ">=8.2.1", | ||
| "@alfresco/adf-content-services": ">=8.2.1", | ||
| "@ngx-translate/core": ">=14.0.0", | ||
| "@ngx-translate/core": ">=17.0.0", |
There was a problem hiding this comment.
The @ngx-translate/core >=17.0.0 in dependencies is incompatible with the stated Angular peer dependencies of >=14.1.3. The @ngx-translate/core v17 requires Angular 17 or higher. Since this library has @ngx-translate/core as a direct dependency (not a peer dependency), it will force installation of ngx-translate 17 which will break for consumers using Angular 14-16. Consider updating the Angular peer dependencies to >=17.0.0 to reflect the actual compatibility requirements.



Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/ACS-11213
What is the new behaviour?
Corrected ngx translate version in libs
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: