Skip to content

[ACS-11213] Updated ngx translate in libs#11699

Merged
AleksanderSklorz merged 1 commit intodevelopfrom
ACS-11213-Upgrade-ngx-translate-to-v17-branch-2
Feb 27, 2026
Merged

[ACS-11213] Updated ngx translate in libs#11699
AleksanderSklorz merged 1 commit intodevelopfrom
ACS-11213-Upgrade-ngx-translate-to-v17-branch-2

Conversation

@AleksanderSklorz
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/ACS-11213

What is the new behaviour?
Corrected ngx translate version in libs

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@sonarqubecloud
Copy link

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the @ngx-translate/core dependency from versions 14.0.0 and 16.0.0 to 17.0.0 across five ADF library packages. The update aligns these library peer dependencies with the root package.json, which already uses @ngx-translate/core ^17.0.0. This is a refactoring change that standardizes the ngx-translate version across all ADF libraries.

Changes:

  • Updated @ngx-translate/core from >=14.0.0 to >=17.0.0 in three libraries (process-services, process-services-cloud, insights)
  • Updated @ngx-translate/core from >=16.0.0 to >=17.0.0 in two libraries (core, content-services)

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
lib/process-services/package.json Updated @ngx-translate/core peer dependency from >=14.0.0 to >=17.0.0
lib/process-services-cloud/package.json Updated @ngx-translate/core peer dependency from >=14.0.0 to >=17.0.0
lib/insights/package.json Updated @ngx-translate/core direct dependency from >=14.0.0 to >=17.0.0
lib/core/package.json Updated @ngx-translate/core peer dependency from >=16.0.0 to >=17.0.0
lib/content-services/package.json Updated @ngx-translate/core peer dependency from >=16.0.0 to >=17.0.0

"@angular/router": ">=14.1.3",
"@alfresco/js-api": ">=9.2.1",
"@ngx-translate/core": ">=16.0.0",
"@ngx-translate/core": ">=17.0.0",
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update to @ngx-translate/core >=17.0.0 may be incompatible with the stated Angular peer dependency of >=14.1.3. The @ngx-translate/core v17 requires Angular 17 or higher. This could cause issues for consumers using Angular versions 14-16 with this library. Consider either:

  1. Updating the Angular peer dependencies to >=17.0.0 to reflect the actual compatibility requirements, or
  2. Verifying that @ngx-translate/core 17 actually works with Angular 14+ and documenting this if needed.

The same issue applies to lib/process-services/package.json and lib/process-services-cloud/package.json which also specify Angular >=14.1.3.

Copilot uses AI. Check for mistakes.
"@alfresco/adf-core": ">=8.2.1",
"@alfresco/adf-content-services": ">=8.2.1",
"@ngx-translate/core": ">=14.0.0"
"@ngx-translate/core": ">=17.0.0"
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update to @ngx-translate/core >=17.0.0 may be incompatible with the stated Angular peer dependency of >=14.1.3. The @ngx-translate/core v17 requires Angular 17 or higher. This could cause issues for consumers using Angular versions 14-16 with this library. Consider updating the Angular peer dependencies to >=17.0.0 to reflect the actual compatibility requirements.

Copilot uses AI. Check for mistakes.
"@alfresco/adf-content-services": ">=8.2.1",
"@apollo/client": ">=3.7.2",
"@ngx-translate/core": ">=14.0.0",
"@ngx-translate/core": ">=17.0.0",
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update to @ngx-translate/core >=17.0.0 may be incompatible with the stated Angular peer dependency of >=14.1.3. The @ngx-translate/core v17 requires Angular 17 or higher. This could cause issues for consumers using Angular versions 14-16 with this library. Consider updating the Angular peer dependencies to >=17.0.0 to reflect the actual compatibility requirements.

Copilot uses AI. Check for mistakes.
"@angular/router": ">=16.0.0",
"@mat-datetimepicker/core": ">=12.0.1",
"@ngx-translate/core": ">=16.0.0",
"@ngx-translate/core": ">=17.0.0",
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update to @ngx-translate/core >=17.0.0 may be incompatible with the stated Angular peer dependency of >=16.0.0. The @ngx-translate/core v17 requires Angular 17 or higher. This could cause issues for consumers using Angular 16 with this library. Consider updating the Angular peer dependencies to >=17.0.0 to reflect the actual compatibility requirements.

Copilot uses AI. Check for mistakes.
"@alfresco/adf-core": ">=8.2.1",
"@alfresco/adf-content-services": ">=8.2.1",
"@ngx-translate/core": ">=14.0.0",
"@ngx-translate/core": ">=17.0.0",
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @ngx-translate/core >=17.0.0 in dependencies is incompatible with the stated Angular peer dependencies of >=14.1.3. The @ngx-translate/core v17 requires Angular 17 or higher. Since this library has @ngx-translate/core as a direct dependency (not a peer dependency), it will force installation of ngx-translate 17 which will break for consumers using Angular 14-16. Consider updating the Angular peer dependencies to >=17.0.0 to reflect the actual compatibility requirements.

Copilot uses AI. Check for mistakes.
@AleksanderSklorz AleksanderSklorz merged commit ec312d4 into develop Feb 27, 2026
30 of 32 checks passed
@AleksanderSklorz AleksanderSklorz deleted the ACS-11213-Upgrade-ngx-translate-to-v17-branch-2 branch February 27, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants