-
Notifications
You must be signed in to change notification settings - Fork 6
268 Provide grb::set(Matrix out, Matrix mask, Matrix in) #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
268 Provide grb::set(Matrix out, Matrix mask, Matrix in) #314
Conversation
byjtew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, as for the unit-test, you could rely on the matrix factories that we have.
e.g: L masked by I should return I
L being a Lower triangular matrix
I being an identity matrix
b8bf1eb to
3e33029
Compare
|
@aleksamilisavljevic @byjtew -- apologies, I thought this one was merged ages ago but found it still open just now. I've rebased it (and weirdly enough indeed a component from this MR was already in utils?) and will look at it more shortly: at the moment it builds but not sure if it passes unit tests, plus I see a spec for the missing primitive should still be provided). I'll take those remainder, hopefully small, steps over the coming days:) |
…sently it trips an internal static_assert. Fixing that would be a first TODO
…same strategy as for the mxm, i.e., get as many SPAs as possible and use those to parallelise
|
It's back up with unit tests passing, still a few TODOs:
|
|
Upgraded unit test -- running the full suite before continuing some other time |
|
All tests pass at this point, by the way (test results from over the weekend and including for LPF). Only one TODO remaining, which is the parallelisation of this function in the |
…pares for its use with grb::set(matrix,matrix,matrix)
Closes #268