Skip to content

368 solver transition path doesnt have a smoke nor performance test #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anyzelman wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

368 solver transition path doesnt have a smoke nor performance test #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d45e476
Resolve some compiler warnings from utils/parser
anyzelman Jul 15, 2025
5953f90
Add smoke test for transition path and enable its build
anyzelman Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions include/graphblas/utils/parser/matrixFileReader.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,8 @@ namespace grb {
T val;
// read until we drop
while( (infile >> row >> col >> val) ) {
assert( row >= 0 );
assert( col >= 0 );
(void) ++properties._entries;
(void) ++properties._nz;
// if symmetric, count non-diagonal entries twice
Expand Down Expand Up @@ -170,11 +172,11 @@ namespace grb {
++properties._nz;
}
// update dimensions
if( row > properties._m ) {
properties._m = row;
if( static_cast< size_t >( row ) > properties._m ) {
properties._m = static_cast< size_t >( row );
}
if( col > properties._n ) {
properties._n = col;
if( static_cast< size_t >( col ) > properties._n ) {
properties._n = static_cast< size_t >( col );
}
}
// correct _m and _n
Expand Down
15 changes: 15 additions & 0 deletions tests/smoke/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,21 @@ add_grb_executables( kcore_decomposition kcore_decomposition.cpp
BACKENDS reference reference_omp hyperdags nonblocking bsp1d hybrid
)

# transition path smoke tests
add_grb_executable_custom( conjugate_gradient_tp_sequential conjugate_gradient_tp.cpp
LINK_LIBRARIES spsolver_sequential backend_headers_nodefs OpenMP::OpenMP_CXX
)

add_grb_executable_custom( conjugate_gradient_tp_shmem_parallel conjugate_gradient_tp.cpp
LINK_LIBRARIES spsolver_shmem_parallel backend_headers_nodefs OpenMP::OpenMP_CXX
)

if( TARGET spsolver_shmem_blocking )
add_grb_executable_custom( conjugate_gradient_tp_shmem_blocking conjugate_gradient_tp.cpp
LINK_LIBRARIES spsolver_shmem_blocking backend_headers_nodefs OpenMP::OpenMP_CXX
)
endif()

# targets to list and build the test for this category
get_property( smoke_tests_list GLOBAL PROPERTY tests_category_smoke )
add_custom_target( "list_tests_category_smoke"
Expand Down
Loading