Skip to content

Conversation

@djelovina
Copy link
Collaborator

ALP implementation of Ising Machine - Simulated Bifurcation

Denis Jelovina added 5 commits July 15, 2025 18:03
Add vector_print function and update test data for Ising machine SB
…ization and update test cases for energy validation
…gn function and update test cases to use integer types for matrices and vectors
@djelovina djelovina requested a review from anyzelman July 16, 2025 14:09
@djelovina djelovina added the enhancement New feature or request label Jul 16, 2025
@djelovina djelovina linked an issue Jul 16, 2025 that may be closed by this pull request
@djelovina
Copy link
Collaborator Author

djelovina commented Jul 16, 2025

Relate to #370 (comment)
set with mask is resizing the vector, therefore I use foldl

foldl< descr_dense >( y_comp, mask, ring.template getZero< IOType >(), grb::operators::right_assign<bool,IOType,IOType>() );

@anyzelman is there any better option here?

@djelovina
Copy link
Collaborator Author

djelovina commented Jul 21, 2025

I have a general question, operator, monoid and semiring are passed in the argument list, is there any good reason why they are not template arguments? I ask this because I feel that (element-wise) operators like abs(x)<1 could be more simply defined in a more structured template-base approach.. @anyzelman

@anyzelman
Copy link
Member

I have a general question, operator, monoid and semiring are passed in the argument list, is there any good reason why they are not template arguments? I ask this because I feel that (element-wise) operators like abs(x)<1 could be more simply defined in a more structured template-base approach.. @anyzelman

We had this a long long time ago, but found it was easier to program if we could instantiate these algebraic structures and just pass them around, leaving it to C++ to infer the abstract (algebraic) types. I'm not sure if I get your comment re abs though, could you elaborate (maybe in a separate issue)?

@anyzelman anyzelman added this to the v0.9 milestone Oct 17, 2025
@anyzelman
Copy link
Member

Attached this to milestone 0.9 btw (so blocked by 0.8)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ising Machine Simulated-bifurcation

3 participants