-
Notifications
You must be signed in to change notification settings - Fork 6
Added checks on output vector in mxv #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
The MR fixes it for reference and reference_omp, but I thought you mentioned all other backends also run into this issue @GiovaGa ? |
|
You are definitely right. I have now fixed also for the nonblocking backend. |
778c24f to
e4c0a49
Compare
|
Running CI, running all unit & smoke tests with LPF. Looks ready to merge if these are both OK. Concept release notes: Prior to this MR, calling Thanks to @GiovaGa for spotting the bug and providing the fixes for the |
GiovaGa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me.
My only observation is that it may make sense to add an assert in exec_tests to guarantee that indeed at least one vector is not dense, as going quickly through the test, this doesn't seem obvious (and the function exec_tests does not specify such precondition)
|
Right now, the test fails when running with 16 processes (and only in that case) |
Resolves #400