-
Notifications
You must be signed in to change notification settings - Fork 6
Provide put & get message passing primitives for the bsp1d backend #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
GiovaGa
wants to merge
13
commits into
develop
Choose a base branch
from
405-provide-put-get-message-passing-primitives-for-the-bsp1d-backend
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0354847
Basic functions and small test
GiovaGa 6e2f24f
fixup! Basic functions and small test
GiovaGa 401e5e3
Some integration with pre-existing stuff
GiovaGa a057d3a
Restructuring rdma to conform to proposed public interface
GiovaGa 400a46d
Transformed namespace to class + added base and reference implementation
GiovaGa 66862bd
Review changes
GiovaGa 7245bfa
Implemented reference RDMA
GiovaGa 119e7a3
fixup! Implemented reference RDMA
GiovaGa adb26f0
Fixed signatures and such in base & reference
GiovaGa 04f491a
Better test + some fixes | a race condition remains...
GiovaGa 1ee28fd
RDMA now working + documentation - TODO: local registration
GiovaGa 08f30ca
Added deregistration + small bugfix for random crashing with multiple…
GiovaGa ca8f86e
Clearer registered slot backend + remember also local slots
GiovaGa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
|
|
||
| /* | ||
| * Copyright 2021 Huawei Technologies Co., Ltd. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| /** | ||
| * @file | ||
| * | ||
| * Exposes facilities for Remote Direct Memory Access | ||
| * | ||
| * @author G. Gaio | ||
| * @date 16th of December, 2025 | ||
| */ | ||
|
|
||
| #ifndef _H_GRB_BASE_RDMA | ||
| #define _H_GRB_BASE_RDMA | ||
|
|
||
| #include <cstddef> //size_t | ||
|
|
||
| #include <stdint.h> // SIZE_MAX | ||
|
|
||
| #include <graphblas/backends.hpp> | ||
| #include <graphblas/rc.hpp> | ||
|
|
||
| #include "config.hpp" | ||
|
|
||
|
|
||
| namespace grb { | ||
|
|
||
| /** | ||
| * For backends that support multiple user processes this class defines some | ||
| * basic primitives to support RDMA programming. | ||
| * | ||
| * All backends must implement this interface, including backends that do not | ||
| * support multiple user processes. The interface herein defined hence ensures | ||
| * to allow for trivial implementations for single user process backends. | ||
| */ | ||
| template< Backend implementation > | ||
| class rdma { | ||
| public: | ||
| template< typename T > | ||
| static grb::RC register_global( T &buf); | ||
|
|
||
| template< typename T > | ||
| static grb::RC register_global( grb::Vector< T, grb::reference > &buf ); | ||
|
|
||
| template< typename T > | ||
| static grb::RC get( const size_t src_pid, T &src, T &dst ); | ||
|
|
||
| template< | ||
| grb::Descriptor descr = descriptors::no_operation, | ||
| grb::Backend backend = grb::reference, | ||
GiovaGa marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| typename T, | ||
| typename Coords | ||
| > | ||
| static grb::RC get( const size_t src_pid, const grb::Vector< T, backend, Coords > &src, grb::Vector< T, backend, Coords > &dst ); | ||
|
|
||
| template< typename T > | ||
| static grb::RC put( const T &src, const size_t dst_pid, T &dst ); | ||
|
|
||
| template< | ||
| grb::Descriptor descr = descriptors::no_operation, | ||
| grb::Backend backend = grb::reference, | ||
GiovaGa marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| typename T, | ||
| typename Coords | ||
| > | ||
| static grb::RC put( const grb::Vector< T, backend, Coords > &src, const size_t dst_pid, grb::Vector< T, backend, Coords > &dst); | ||
GiovaGa marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| }; // end class ``rdma'' | ||
|
|
||
| } // namespace grb | ||
|
|
||
| #endif // end _H_GRB_BASE_SPMD | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.