Clang tidy naming convention

.clang-tidy

@@ -1,24 +1,101 @@
 Checks: '-*,readability-identifier-naming'
 
 CheckOptions:
-  # 1. Member Variables: camelBack with a trailing underscore (e.g., memberVariableTest_)
-  - key:             readability-identifier-naming.MemberCase
+  - key:             readability-identifier-naming.AggressiveDependentMemberLookup
+    value:           1
+
+  - key:             readability-identifier-naming.AbstractClassCase
+    value:           CamelCase
+
+  - key:             readability-identifier-naming.ClassCase
+    value:           CamelCase
+
+  - key:             readability-identifier-naming.ClassConstexprCase
     value:           camelBack
-  - key:             readability-identifier-naming.MemberSuffix
+  - key:             readability-identifier-naming.ClassConstexprSuffix
+    value:           _
+
+  - key:             readability-identifier-naming.ClassConstantCase
+    value:           camelBack
+  - key:             readability-identifier-naming.ClassConstantSuffix
+    value:           _
+
+  - key:             readability-identifier-naming.ClassMemberCase
+    value:           camelBack
+  - key:             readability-identifier-naming.ClassMemberSuffix
     value:           _
 
-  # 2. Functions: CamelCase (e.g., CalculateTotal)
+  - key:             readability-identifier-naming.ClassMethodCase
+    value:           CamelCase
+  - key:             readability-identifier-naming.ClassMethodIgnoredRegexp
+    value:           "^(begin|cbegin|end|cend|rbegin|crbegin|rend|crend|size|empty)$"
+
+  - key:             readability-identifier-naming.EnumCase
+    value:           CamelCase
+
+  - key:             readability-identifier-naming.EnumConstantCase
+    value:           UPPER_CASE
+
   - key:             readability-identifier-naming.FunctionCase
     value:           CamelCase
 
-  # 3. Local Variables/Parameters: camelBack (e.g., totalValue)
-  - key:             readability-identifier-naming.VariableCase
+  - key:             readability-identifier-naming.GlobalConstexprVariableCase
+    value:           UPPER_CASE
+
+  - key:             readability-identifier-naming.GlobalVariableCase
     value:           camelBack
-  - key:             readability-identifier-naming.ParameterCase
+
+  - key:             readability-identifier-naming.LocalVariableCase
     value:           camelBack
 
-  # 4. Classes/Structs: CamelCase (e.g., MyClass)
-  - key:             readability-identifier-naming.ClassCase
+  - key:             readability-identifier-naming.MacroDefinitionCase
+    value:           UPPER_CASE
+
+  - key:             readability-identifier-naming.MacroDefinitionIgnoredRegexp
+    value:           '^[A-Z]+(_[A-Z]+)*_$'
+
+  - key:             readability-identifier-naming.MemberCase
+    value:           camelBack
+  - key:             readability-identifier-naming.MemberSuffix
+    value:           _
+
+  - key:             readability-identifier-naming.MethodCase
     value:           CamelCase
+  - key:             readability-identifier-naming.MethodIgnoredRegexp
+    value:           "^(begin|cbegin|end|cend|rbegin|crbegin|rend|crend|size|empty)$"
+
+  - key:             readability-identifier-naming.NamespaceCase
+    value:           lower_case
+
+  - key:             readability-identifier-naming.ParameterCase
+    value:           camelBack
+
+  - key:             readability-identifier-naming.ScopedEnumConstantCase
+    value:           UPPER_CASE
+
   - key:             readability-identifier-naming.StructCase
-    value:           CamelCase
+    value:           CamelCase
+
+  - key:             readability-identifier-naming.TemplateParameterCase
+    value:           CamelCase
+
+  # Includes the fix for std::iterator_traits compatibility
+  - key:             readability-identifier-naming.TypeAliasCase
+    value:           CamelCase
+  - key:             readability-identifier-naming.TypeAliasIgnoredRegexp
+    value:           "^(iterator_category|difference_type|value_type|pointer|reference|const_pointer|const_reference)$"
+
+  - key:             readability-identifier-naming.TypedefCase
+    value:           CamelCase
+
+  - key:             readability-identifier-naming.TypeTemplateParameterCase
+    value:           CamelCase
+
+  - key:             readability-identifier-naming.ValueTemplateParameterCase
+    value:           camelBack
+
+  - key:             readability-identifier-naming.VariableCase
+    value:           camelBack
+
+  - key:             readability-identifier-naming.IgnoreMainLikeFunctions
+    value:           1

apps/bsp_test_suite.cpp

@@ -23,11 +23,11 @@ limitations under the License.
 #include "osp/graph_implementations/adj_list_impl/computational_dag_edge_idx_vector_impl.hpp"
 #include "test_suite_runner/BspScheduleRecompTestSuiteRunner.hpp"
 
-using graph_t = osp::computational_dag_edge_idx_vector_impl_def_int_t;
+using GraphT = osp::ComputationalDagEdgeIdxVectorImplDefIntT;
 
 int main(int argc, char *argv[]) {
-    osp::BspScheduleRecompTestSuiteRunner<graph_t> runner;
-    return runner.run(argc, argv);
+    osp::BspScheduleRecompTestSuiteRunner<GraphT> runner;
+    return runner.Run(argc, argv);
 
     return 0;
 }

apps/coarser_plotter.cpp

@@ -26,74 +26,74 @@ limitations under the License.
 #include "osp/graph_implementations/adj_list_impl/computational_dag_edge_idx_vector_impl.hpp"
 
 using namespace osp;
-using Graph_t = computational_dag_edge_idx_vector_impl_def_int_t;
+using GraphT = ComputationalDagEdgeIdxVectorImplDefIntT;
 
 int main(int argc, char *argv[]) {
     if (argc < 3) {
         std::cerr << "Usage: " << argv[0] << " <graph> <output file>\n" << std::endl;
         return 1;
     }
 
-    std::string graph_file = argv[1];
-    std::string graph_name = graph_file.substr(graph_file.rfind("/") + 1, graph_file.rfind(".") - graph_file.rfind("/") - 1);
+    std::string graphFile = argv[1];
+    std::string graphName = graphFile.substr(graphFile.rfind("/") + 1, graphFile.rfind(".") - graphFile.rfind("/") - 1);
 
-    Graph_t graph;
-    bool status = file_reader::readGraph(graph_file, graph);
+    GraphT graph;
+    bool status = file_reader::ReadGraph(graphFile, graph);
     if (!status) {
         std::cout << "Failed to read graph\n";
         return 1;
     }
 
-    SarkarParams::MulParameters<v_workw_t<Graph_t>> params;
-    params.commCostVec = std::vector<v_workw_t<Graph_t>>({1, 2, 5, 10, 20, 50, 100, 200, 500, 1000});
-    params.max_num_iteration_without_changes = 3;
-    params.leniency = 0.005;
-    params.maxWeight = 15000;
-    params.smallWeightThreshold = 4000;
-    params.buffer_merge_mode = SarkarParams::BufferMergeMode::FULL;
+    sarkar_params::MulParameters<VWorkwT<GraphT>> params;
+    params.commCostVec_ = std::vector<VWorkwT<GraphT>>({1, 2, 5, 10, 20, 50, 100, 200, 500, 1000});
+    params.maxNumIterationWithoutChanges_ = 3;
+    params.leniency_ = 0.005;
+    params.maxWeight_ = 15000;
+    params.smallWeightThreshold_ = 4000;
+    params.bufferMergeMode_ = sarkar_params::BufferMergeMode::FULL;
 
-    SarkarMul<Graph_t, Graph_t> coarser;
-    coarser.setParameters(params);
+    SarkarMul<GraphT, GraphT> coarser;
+    coarser.SetParameters(params);
 
-    Graph_t coarse_graph;
-    std::vector<vertex_idx_t<Graph_t>> contraction_map;
+    GraphT coarseGraph;
+    std::vector<VertexIdxT<GraphT>> contractionMap;
 
-    Graph_t graph_copy = graph;
-    bool ignore_vertex_types = false;
+    GraphT graphCopy = graph;
+    bool ignoreVertexTypes = false;
 
-    if (ignore_vertex_types) {
-        for (const auto &vert : graph_copy.vertices()) {
-            graph_copy.set_vertex_type(vert, 0);
+    if (ignoreVertexTypes) {
+        for (const auto &vert : graphCopy.Vertices()) {
+            graphCopy.SetVertexType(vert, 0);
         }
     }
 
-    coarser.coarsenDag(graph_copy, coarse_graph, contraction_map);
+    coarser.CoarsenDag(graphCopy, coarseGraph, contractionMap);
 
-    std::vector<unsigned> colours(contraction_map.size());
-    for (std::size_t i = 0; i < contraction_map.size(); ++i) {
-        colours[i] = static_cast<unsigned>(contraction_map[i]);
+    std::vector<unsigned> colours(contractionMap.size());
+    for (std::size_t i = 0; i < contractionMap.size(); ++i) {
+        colours[i] = static_cast<unsigned>(contractionMap[i]);
     }
 
-    std::ofstream out_dot(argv[2]);
-    if (!out_dot.is_open()) {
+    std::ofstream outDot(argv[2]);
+    if (!outDot.is_open()) {
         std::cout << "Unable to write/open output file.\n";
         return 1;
     }
 
     DotFileWriter writer;
-    writer.write_colored_graph(out_dot, graph, colours);
+    writer.WriteColoredGraph(outDot, graph, colours);
 
     if (argc >= 4) {
-        std::ofstream coarse_out_dot(argv[3]);
-        if (!coarse_out_dot.is_open()) {
+        std::ofstream coarseOutDot(argv[3]);
+        if (!coarseOutDot.is_open()) {
             std::cout << "Unable to write/open output file.\n";
             return 1;
         }
 
-        std::vector<unsigned> coarse_colours(coarse_graph.num_vertices());
-        std::iota(coarse_colours.begin(), coarse_colours.end(), 0);
+        std::vector<unsigned> coarseColours(coarseGraph.NumVertices());
+        std::iota(coarseColours.begin(), coarseColours.end(), 0);
 
-        writer.write_colored_graph(coarse_out_dot, coarse_graph, coarse_colours);
+        writer.WriteColoredGraph(coarseOutDot, coarseGraph, coarseColours);
     }
 
     return 0;