Add :mini and :micro variants for Heroicons#40
Open
bslobodin wants to merge 2 commits intoAliOsm:mainfrom
Open
Add :mini and :micro variants for Heroicons#40bslobodin wants to merge 2 commits intoAliOsm:mainfrom
bslobodin wants to merge 2 commits intoAliOsm:mainfrom
Conversation
Update the Hero icon generator to produce all 4 Heroicon variants: - solid (24x24, filled) - outline (24x24, 1.5px stroke) - mini (20x20, filled) - micro (16x16, filled) The generator now dynamically determines available variants per icon, since 8 icons lack a micro variant in the upstream heroicons source. Refs: AliOsm#39
Generated 324 mini (20x20) and 316 micro (16x16) variant components.
8 icons lack a micro variant upstream: arrow-left-on-rectangle,
arrow-right-on-rectangle, arrow-small-{down,left,right,up},
minus-small, and plus-small.
Total hero icon files: 1,614 (up from 974).
Owner
|
Hello @bslobodin and thanks for your PR. I didn't add these when I implemented the gem as I thought these are a simple size change could be done using CSS. Is this correct or these have a special property? |
Author
|
👋 @AliOsm these are actually not just size variants you can replicate with CSS, I am certain they redrew every icon from scratch for each size. A nice concrete example is
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Adds the two missing Heroicon variants —
:mini(20x20, solid fill) and:micro(16x16, solid fill) — to complement the existing:solidand:outlinevariants.Closes #39
Details
The Heroicons library ships 4 variants, but only 2 were supported:
outlinesolidminimicro8 icons that don't have a micro variant upstream (
arrow-left-on-rectangle,arrow-right-on-rectangle,arrow-small-{down,left,right,up},minus-small,plus-small) correctly skip the:micromethod and wrapper class.Usage
Changes
Split into two commits for easier review:
VARIANTSconstant