Add hint to not use LIMIT in "Simple aggregation"#37
Open
thomasboyt wants to merge 1 commit intoAlisdairO:masterfrom
Open
Add hint to not use LIMIT in "Simple aggregation"#37thomasboyt wants to merge 1 commit intoAlisdairO:masterfrom
thomasboyt wants to merge 1 commit intoAlisdairO:masterfrom
Conversation
andrei-polukhin
approved these changes
Nov 19, 2021
andrei-polukhin
left a comment
andrei-polukhin
left a comment
There was a problem hiding this comment.
Agree! The task is aggregation, so we should highlight not to use ORDER with LIMIT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that this question is easily solvable without using the
MAXfunction as intended:This just adds an extra line telling answerers not to use
LIMIT(similar to the hint on a previous question).