Skip to content

Conversation

@BSWANG
Copy link
Member

@BSWANG BSWANG commented Dec 18, 2025

Note

Introduces a more robust VF discovery and simplifies RPC/CNI VF handling.

  • RPC API change: removes VfType enum/field from rpc.proto; ENIInfo now only carries optional VfId (regenerated rpc.pb.go/* files; protoc version bump)
  • CNI/VF setup: prepareVF no longer takes/derives VfType; always sets up VF via vf.SetupDriverAndGetNetInterface using VfId
  • VF driver: GetBDFbyVFID now auto-selects config path between /var/rdma/eni_topo and /var/run/hc-eni-host/vf-topo-vpc; exposes config path vars and adds comprehensive tests
  • ENI remote: stop mapping annotations to VfType; propagate VfId from status only
  • Tests: updated across eni and plugin/terway to reflect API/signature changes and new VF path fallback

Written by Cursor Bugbot for commit ee19cc4. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on December 21

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@BSWANG BSWANG force-pushed the feature/eno-topo-path-fallback branch from dc27b89 to 7bf9a5b Compare December 18, 2025 11:56
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.46%. Comparing base (c1afe28) to head (ee19cc4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
plugin/driver/vf/vf.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #954      +/-   ##
==========================================
+ Coverage   61.30%   61.46%   +0.15%     
==========================================
  Files         133      133              
  Lines       16639    16632       -7     
==========================================
+ Hits        10201    10223      +22     
+ Misses       5231     5202      -29     
  Partials     1207     1207              
Flag Coverage Δ
unittests 61.46% <80.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BSWANG BSWANG changed the title ENO api fallback to hc-eni-host path [WIP]ENO api fallback to hc-eni-host path Dec 19, 2025
@BSWANG BSWANG force-pushed the feature/eno-topo-path-fallback branch from 7bf9a5b to d4119d8 Compare December 19, 2025 07:02
@BSWANG BSWANG force-pushed the feature/eno-topo-path-fallback branch 2 times, most recently from 63a4050 to b26b25c Compare December 22, 2025 12:07
Signed-off-by: bingshen.wbs <bingshen.wbs@alibaba-inc.com>
@BSWANG BSWANG force-pushed the feature/eno-topo-path-fallback branch from b26b25c to ee19cc4 Compare December 23, 2025 02:26
@BSWANG BSWANG changed the title [WIP]ENO api fallback to hc-eni-host path ENO api fallback to hc-eni-host path Dec 30, 2025
@l1b0k l1b0k merged commit 955b492 into AliyunContainerService:main Dec 30, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants