fix(aliyun): enhance EFLO service deletion handling and testing#985
fix(aliyun): enhance EFLO service deletion handling and testing#985BSWANG merged 1 commit intoAliyunContainerService:mainfrom
Conversation
- Introduced a backoff strategy for polling the deletion status of Elastic Network Interfaces (ENIs). - Updated the DeleteElasticNetworkInterface method to handle various deletion scenarios, including immediate success, errors, and polling timeouts. - Enhanced unit tests to cover multiple deletion scenarios and ensure robust error handling. Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
|
@cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Codecov Report❌ Patch coverage is
❌ Your project status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes. Additional details and impacted files@@ Coverage Diff @@
## main #985 +/- ##
==========================================
- Coverage 79.63% 79.62% -0.02%
==========================================
Files 120 120
Lines 15214 15239 +25
==========================================
+ Hits 12116 12134 +18
- Misses 2047 2054 +7
Partials 1051 1051
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Note
Medium Risk
Changes ENI deletion behavior by adding polling and new failure modes/timeouts, which could impact cleanup timing and error handling in callers if the EFLO API is slow or returns transient describe errors.
Overview
EFLOService.DeleteElasticNetworkInterfacenow treats delete as async: after a successful delete request it pollsDescribeLeniNetworkInterface(with a newgetDeleteCheckBackoffconfiguration) until the LENI disappears, errors if it entersDeleteFailed, and returns a clearer timeout error;1011(not found) continues to be treated as success without polling.Unit tests are refactored to use a single
gomonkey.ApplyFuncSeqfor multiple delete responses, override the backoff for fast runs, and add coverage for the new polling behaviors (confirmed deletion, immediate API error, already-deleted, polling timeout, andDeleteFailed).Written by Cursor Bugbot for commit 32e3e2a. Configure here.