Merged
Conversation
Oracle does not support DATE() and treats DATE as a reserved keyword, which breaks parsing and grouping.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Oracle database compatibility issues in the ActivityChartWidget by making date aggregation database-agnostic. Oracle doesn't support the DATE() function and treats DATE as a reserved keyword, which was causing SQL parsing errors.
- Introduced driver-specific date expression using
TRUNC(created_at)for Oracle andDATE(created_at)for other databases - Replaced the reserved keyword
datealias with a safeactivity_datealias - Updated groupBy and orderBy clauses to use raw expressions for consistency
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oracle does not support
DATE()and treatsDATEas a reserved keyword, which breaks parsing and grouping.Make activity date aggregation database-agnostic by replacing the
DATE()function and reserved date alias with a driver-specificDATEexpression and a safe alias, fixing Oracle SQL errors while preserving correct grouping across all supported databases.Also, using an alias in a
GROUP BYstatement is only supported in MySQL, as far as I know.