forked from LizardByte/Sunshine
-
-
Notifications
You must be signed in to change notification settings - Fork 110
fix: 延迟程序启动后立即检查显示器列表 #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Yundi339
wants to merge
1
commit into
master
Choose a base branch
from
feat_optvdd
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+11
−1
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里复用 session_t 的 StateRetryTimer 做启动延迟恢复会被后续的 timer->setup_timer(...) 覆盖/取消(例如 configure_display 在成功路径会调用 timer->setup_timer(nullptr)),导致启动时的 crash recovery 可能根本不执行。更严重的是:如果旧的 persistent file 还没被 restore/revert 清理掉,就先进入 apply_config,有可能覆盖掉旧持久化数据,从而丢失“原始显示拓扑”信息。建议把“启动恢复”从共享 retry timer 中解耦(独立的一次性延迟任务/线程,或在第一次 configure_display 前强制完成一次恢复/至少加载并清理旧持久化文件),以保证恢复逻辑必定发生且不会与后续重试定时器互相踩踏。