app_rpt: Use ast_str for stats url

[mkmer]

Summary by CodeRabbit

• Refactor
  • Standardized string handling for reporting paths, simplifying how report URLs and parameters are assembled.
  • Improved memory management and cleanup for status-posting operations, reducing risk of leaks and increasing stability of reporting features.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

• 🔍 Trigger a full review

📝 Walkthrough

Walkthrough

Replaces plain C string usage with struct ast_str in apps/app_rpt: statpost now accepts struct ast_str *pairs, struct statpost.stats_url is struct ast_str *, and URL assembly, callers, logging, and cleanup updated to use the ast_str API. (50 words)

Changes

Cohort / File(s)	Summary
Header: struct change apps/app_rpt/app_rpt.h	Changed struct statpost field stats_url from char * to struct ast_str * — type and memory-management change requiring ast_str create/free usage.
Core refactor: statpost and callers apps/app_rpt.c	Refactored statpost signature to accept struct ast_str *pairs; replaced local/heap char buffers with ast_str_create/ast_str_set/ast_str_buffer; updated callers (perform_statpost, do_key_post, do_link_post, etc.) to pass ast_str objects; adjusted logging and added ast_str free/cleanup on error paths.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• app_rpt: prevent html in logfile, add "words" to http codes #840 — Modifies the same perform_statpost/statpost code paths and HTTP logging/response handling; likely to overlap.

Suggested reviewers

• Allan-N
• InterLinked1

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: refactoring to use ast_str for the stats URL instead of char* buffers.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch ast_str-for-stats-url

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

• ✨ 136.113.208.247/32 (new)
• 34.170.211.100/32
• 35.222.179.152/32

Failure to add the new IP will result in interrupted reviews.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[mkmer]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[mkmer]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Note

Unit test generation is a public access feature. Expect some limitations and changes as we gather feedback and continue to improve it.

---

Generating unit tests... This may take up to 20 minutes.

[coderabbitai]

✅ Created PR with unit tests: #925