AD_FillWaves: Fix edge case with sweeps from different experiments

In ff131df (AD_FillWaves: Handle sweeps without analysis functions
better, 2022-08-08) we added better support for detecting ongoing sweeps
which don't have analysis functions attached.

That commit failed to see that when we are loading sweeps from different
experiments the last sweep from experiment B can not be found in the
labnotebook of the first experiment. And then lastSweepStimsetCycleIDs
is correctly an invalid wave ref.

Stepping back makes us realize that we only need to perform that check
when we are a databrowser as DAQ is never ongoing in the sweepbrowser.

While at it we also move fetching the SCI of the last sweep out of the
for loop.

Author: t-b

Packages/MIES/MIES_AnalysisFunctions_Dashboard.ipf

@@ -219,11 +219,14 @@ static Function AD_FillWaves(string win, WAVE/T list, WAVE/T info)
 	if(isDataBrowser)
 		device   = BSP_GetDevice(win)
 		acqState = ROVar(GetAcquisitionState(device))
-		DFREF sweepDFR = GetDeviceDataPath(device)
+		DFREF sweepDFR                 = GetDeviceDataPath(device)
+		WAVE  lastSweepStimsetCycleIDs = GetLastSetting(numericalValuesWave[0], WaveMax(totalSweepsPresent), STIMSET_ACQ_CYCLE_ID_KEY, DATA_ACQUISITION_MODE)
+		ASSERT(WaveExists(lastSweepStimsetCycleIDs), "Missing last sweep SCIs")
 	else
 		acqState = AS_INACTIVE
 		DFREF  sweepBrowserDFR = SB_GetSweepBrowserFolder(win)
 		WAVE/T sweepMap        = GetSweepBrowserMap(sweepBrowserDFR)
+		WAVE/ZZ lastSweepStimsetCycleIDs
 
 		WAVE totalMapIndizes = SB_GetMapIndizes(win)
 		ASSERT(DimSize(totalSweepsPresent, ROWS) == DimSize(totalMapIndizes, ROWS), "Expected equal number of sweeps and map indizes")
@@ -257,8 +260,6 @@ static Function AD_FillWaves(string win, WAVE/T list, WAVE/T info)
 			continue
 		endif
 
-		WAVE/Z lastSweepStimsetCycleIDs = GetLastSetting(numericalValues, WaveMax(totalSweepsPresent), STIMSET_ACQ_CYCLE_ID_KEY, DATA_ACQUISITION_MODE)
-
 		key = StringFromList(GENERIC_EVENT, EVENT_NAME_LIST_LBN)
 		WAVE/Z/T anaFuncs = GetLastSetting(textualValues, sweepNo, key, DATA_ACQUISITION_MODE)
 
@@ -305,9 +306,13 @@ static Function AD_FillWaves(string win, WAVE/T list, WAVE/T info)
 
 			if(anaFuncType == INVALID_ANALYSIS_FUNCTION)
 				passed = NaN
-				// current sweep is from the same SCI than the last acquired sweep and DAQ is not inactive
-				ASSERT(WaveExists(lastSweepStimsetCycleIDs), "Missing last sweep SCIs")
-				ongoingDAQ = (lastSweepStimsetCycleIDs[headstage] == stimsetCycleID) && (acqState != AS_INACTIVE)
+
+				if(isDataBrowser)
+					// current sweep is from the same SCI than the last acquired sweep and DAQ is not inactive
+					ongoingDAQ = (lastSweepStimsetCycleIDs[headstage] == stimsetCycleID) && (acqState != AS_INACTIVE)
+				else
+					ongoingDAQ = 0
+				endif
 			else
 				key        = CreateAnaFuncLBNKey(anaFuncType, PSQ_FMT_LBN_SET_PASS, query = 1, waMode = waMode)
 				passed     = GetLastSettingIndepSCI(numericalValues, sweepNo, key, headstage, UNKNOWN_MODE)

Packages/tests/HistoricData/UTF_HistoricDashboard.ipf

@@ -201,3 +201,21 @@ Function TestDashboardSelections()
 	WAVE/Z sweeps = OVS_GetSelectedSweeps(bsPanel, OVS_SWEEP_SELECTION_SWEEPNO)
 	CHECK_EQUAL_WAVES(sweeps, {4, 8, 9, 10, 11, 20, 21}, mode = WAVE_DATA)
 End
+
+static Function TestOngoingDAQBugWithoutAnalysisFunction()
+
+	string sweepBrowsers, sweepBrowser, bsPanel, abWin
+
+	Make/FREE/T files = {"input:H22.03.311.11.08.01.06.nwb", "input:NWB_V1_single_device.nwb"}
+	DownloadFilesIfRequired(files)
+	[abWin, sweepBrowsers] = OpenAnalysisBrowser(files, loadSweeps = 1, multipleSweepBrowser = 0)
+	CHECK_NO_RTE()
+
+	sweepBrowser = StringFromList(0, sweepBrowsers)
+
+	bsPanel = BSP_GetPanel(sweepBrowser)
+	CHECK(WindowExists(bsPanel))
+
+	PGC_SetAndActivateControl(bsPanel, "check_BrowserSettings_DS", val = CHECKBOX_SELECTED)
+	PGC_SetAndActivateControl(bsPanel, "check_BrowserSettings_DB_Passed", val = CHECKBOX_SELECTED)
+End