Skip to content

Commit 4957d01

Browse files
committed
changes
1 parent 43017e4 commit 4957d01

File tree

1 file changed

+28
-25
lines changed

1 file changed

+28
-25
lines changed

.github/workflows/build-pr.yml

Lines changed: 28 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -107,29 +107,32 @@ jobs:
107107
# key: pre-commit|${{ env.PY }}|${{ hashFiles('.pre-commit-config.yaml') }}
108108
# - name: Pre commit
109109
# run: tools/pre-commit/run.sh
110-
#
111-
# CompilationTest:
112-
# name: 👩🏾‍🔬 Compilation of ${{ matrix.source }} ${{ fromJSON('["","with XOP"]')[matrix.hardware] }}
113-
# needs:
114-
# - BuildInstaller
115-
# strategy:
116-
# matrix:
117-
# source: [ git, installer ]
118-
# hardware: [ false, true ]
119-
# exclude:
120-
# # the git source is always checked with hardware support
121-
# - source: git
122-
# hardware: false
123-
# uses: ./.github/workflows/test-igor-workflow.yml
124-
# with:
125-
# job_name: 👩🏾‍🔬 Compilation of ${{ matrix.source }} ${{ fromJSON('["","with XOP"]')[matrix.hardware] }}
126-
# overwrite_job_name: ${{ inputs.is_called_workflow || false }}
127-
# experiment: Packages/tests/Compilation/CompilationTester.pxp
128-
# installer_artifact_name: BuildInstaller-assets
129-
# installer_flags: ${{ fromJSON('["-x skipHardwareXOPs",""]')[matrix.hardware] }} -s ${{ matrix.source }}
130-
# artifact_name: CompilationTest-${{ matrix.source }}-${{ fromJSON('["no-hardware","hardware"]')[matrix.hardware] }}-assets
131-
# timeout_minutes: 60
132-
#
110+
111+
CompilationTest:
112+
name: 👩🏾‍🔬 Compilation of ${{ matrix.source }} ${{ fromJSON('["","with XOP"]')[matrix.hardware] }} v${{ matrix.version }}
113+
needs:
114+
- BuildInstaller
115+
strategy:
116+
matrix:
117+
source: [ git, installer ]
118+
hardware: [ false, true ]
119+
version: [9, 10]
120+
exclude:
121+
# the git source is always checked with hardware support
122+
- source: git
123+
hardware: false
124+
uses: ./.github/workflows/test-igor-workflow.yml
125+
with:
126+
job_name: 👩🏾‍🔬 Compilation of ${{ matrix.source }} ${{ fromJSON('["","with XOP"]')[matrix.hardware] }}
127+
overwrite_job_name: ${{ inputs.is_called_workflow || false }}
128+
experiment: Packages/tests/Compilation/CompilationTester.pxp
129+
target: "[ 'self-hosted', 'Windows', 'IgorPro10']"
130+
installer_artifact_name: BuildInstaller-assets
131+
installer_flags: ${{ fromJSON('["-x skipHardwareXOPs",""]')[matrix.hardware] }} -s ${{ matrix.source }}
132+
artifact_name: CompilationTest-${{ matrix.source }}-${{ fromJSON('["no-hardware","hardware"]')[matrix.hardware] }}-v${{ matrix.version }}-assets
133+
timeout_minutes: 60
134+
major_igorpro_version: ${{ matrix.version }}
135+
133136
# CompilationEachCommitTest:
134137
# name: 👩🏾‍🔬 Compilation of each commit
135138
# if: ${{ !inputs.is_called_workflow }}
@@ -169,7 +172,7 @@ jobs:
169172
needs:
170173
- BuildInstaller
171174
# - Linting
172-
# - CompilationTest
175+
- CompilationTest
173176
strategy:
174177
matrix:
175178
version:
@@ -197,7 +200,7 @@ jobs:
197200
overwrite_job_name: ${{ inputs.is_called_workflow || false }}
198201
experiment: ${{ matrix.experiment }}
199202
target: "[ 'self-hosted', 'Windows', 'IgorPro10']"
200-
artifact_name: TestWithoutHardware-${{ matrix.name }}-${{ matrix.version }}-assets
203+
artifact_name: TestWithoutHardware-${{ matrix.name }}-v${{ matrix.version }}-assets
201204
expensive_checks: "1"
202205
instrument_tests: ${{ fromJson('["0", "1"]')[inputs.do_instrumentation] }}
203206
timeout_minutes: 60

0 commit comments

Comments
 (0)