Skip to content

Commit 50acbc7

Browse files
committed
Fix launcher use of data mappers
1 parent db2f62b commit 50acbc7

File tree

3 files changed

+10
-27
lines changed

3 files changed

+10
-27
lines changed

src/aind_behavior_vr_foraging/data_mappers/__init__.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,6 @@
22
from pathlib import Path
33
from typing import TYPE_CHECKING
44

5-
from aind_behavior_services.session import AindBehaviorSessionModel
6-
from aind_behavior_services.utils import model_from_json_file
7-
from clabe.apps import BonsaiApp, CurriculumSuggestion
8-
from git import Repo
9-
10-
from aind_behavior_vr_foraging.data_contract.utils import calculate_consumed_water
11-
from aind_behavior_vr_foraging.rig import AindVrForagingRig
12-
from aind_behavior_vr_foraging.task_logic import AindVrForagingTaskLogic
13-
145
from ._rig import AindRigDataMapper
156
from ._session import AindSessionDataMapper
167

src/aind_behavior_vr_foraging/data_mappers/_session.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ def __init__(
3333
self,
3434
data_path: os.PathLike,
3535
repo_path: os.PathLike,
36-
curriculum_suggestion_path: Optional[os.PathLike] = None,
36+
curriculum_suggestion: Optional[os.PathLike] | CurriculumSuggestion = None,
3737
session_end_time: Optional[AwareDatetime] = None,
3838
):
3939
self._data_path = data_path
@@ -45,8 +45,11 @@ def __init__(
4545
self.rig_model = model_from_json_file(abs_schemas_path / "rig_input.json", AindVrForagingRig)
4646
self.task_logic_model = model_from_json_file(abs_schemas_path / "tasklogic_input.json", AindVrForagingTaskLogic)
4747

48-
if curriculum_suggestion_path is not None:
49-
curriculum_suggestion = model_from_json_file(Path(curriculum_suggestion_path), CurriculumSuggestion)
48+
if curriculum_suggestion is not None:
49+
if isinstance(curriculum_suggestion, CurriculumSuggestion):
50+
pass
51+
else:
52+
curriculum_suggestion = model_from_json_file(Path(curriculum_suggestion), CurriculumSuggestion)
5053
else:
5154
try:
5255
curriculum_suggestion = model_from_json_file(

src/aind_behavior_vr_foraging/launcher.py

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
from contraqctor.contract.json import SoftwareEvents
1919
from pydantic_settings import CliApp
2020

21-
import aind_behavior_vr_foraging.data_contract.utils
2221
from aind_behavior_vr_foraging import data_contract
2322
from aind_behavior_vr_foraging.data_mappers import AindRigDataMapper, AindSessionDataMapper
2423
from aind_behavior_vr_foraging.rig import AindVrForagingRig
@@ -96,25 +95,15 @@ async def experiment(launcher: Launcher) -> None:
9695
# Push updated trainer state back to the database
9796
picker.push_new_suggestion(suggestion.trainer_state)
9897

99-
try:
100-
total_water_consumed = aind_behavior_vr_foraging.data_contract.utils.calculate_consumed_water(
101-
launcher.session_directory
102-
)
103-
except Exception as e:
104-
logger.warning(f"Could not calculate consumed water: {e}")
105-
total_water_consumed = None
106-
10798
# Mappers
99+
assert launcher.repository.working_tree_dir is not None
108100
ads_session = AindSessionDataMapper(
109-
rig=rig,
110-
session=session,
111-
task_logic=task_logic,
101+
data_path=launcher.session_directory,
102+
repo_path=launcher.repository.working_tree_dir, # type: ignore[arg-type]
112103
curriculum_suggestion=suggestion,
113-
bonsai_app=bonsai_app,
114-
water_consumed_ml=total_water_consumed,
115104
).map()
116105
ads_session.write_standard_file(launcher.session_directory)
117-
ads_rig = AindRigDataMapper(rig=rig).map()
106+
ads_rig = AindRigDataMapper(data_path=launcher.session_directory).map()
118107
ads_rig.write_standard_file(launcher.session_directory)
119108

120109
# Run data qc

0 commit comments

Comments
 (0)