fix: removes redundant subdir (#153)

* fix: remove any redundant copy_original_md_subdir defaults

* update the unittests to have all the required arguments

* fix:update json file with new page response with no CommonPrefixes; updateunit tes with new expected empty list

* Revert "fix:update json file with new page response with no CommonPrefixes; updateunit tes with new expected empty list"

This reverts commit 17763d2.

Author: ajar312

src/aind_data_asset_indexer/utils.py

@@ -553,7 +553,7 @@ def cond_copy_then_sync_core_json_files(
     bucket: str,
     prefix: str,
     s3_client: S3Client,
-    copy_original_md_subdir: str = "original_metadata",
+    copy_original_md_subdir: str,
 ) -> None:
     """
     For a given bucket and prefix

tests/test_utils.py

@@ -994,6 +994,7 @@ def test_cond_copy_then_sync_core_json_files(
                 bucket=bucket,
                 prefix=pfx,
                 s3_client=mock_s3_client,
+                copy_original_md_subdir="original_metadata"
             )
         expected_output_messages = [
             f"WARNING:root:Copy of original metadata already exists at "
@@ -1112,6 +1113,7 @@ def test_cond_copy_then_sync_core_json_files_mismatch(
                 bucket=bucket,
                 prefix=pfx,
                 s3_client=mock_s3_client,
+                copy_original_md_subdir="original_metadata",
             )
         expected_log_messages = [
             f"INFO:root:Source file "