fix: updates schema version check to handle new core schemas

Author: jtyoung84

src/aind_data_schema/core/session.py

@@ -218,10 +218,9 @@ class ManipulatorModule(DomeModule):
         title="Manipulator coordinates",
     )
     anatomical_coordinates: Optional[Coordinates3d] = Field(default=None, title="Anatomical coordinates")
-    anatomical_reference: Optional[Literal[CoordinateReferenceLocation.BREGMA,
-                                           CoordinateReferenceLocation.LAMBDA]] = Field(
-                                               default=None, title="Anatomical coordinate reference"
-                                               )
+    anatomical_reference: Optional[Literal[CoordinateReferenceLocation.BREGMA, CoordinateReferenceLocation.LAMBDA]] = (
+        Field(default=None, title="Anatomical coordinate reference")
+    )
     surface_z: Optional[Decimal] = Field(default=None, title="Surface z")
     surface_z_unit: SizeUnit = Field(SizeUnit.UM, title="Surface z unit")
     dye: Optional[str] = Field(default=None, title="Dye")

src/aind_data_schema/utils/schema_version_bump.py

@@ -50,11 +50,12 @@ def _get_list_of_models_that_changed(self) -> List[AindCoreModel]:
             if default_filename.find(".") != -1:
                 schema_filename = default_filename[: default_filename.find(".")] + "_schema.json"
             main_branch_schema_path = self.json_schemas_location / schema_filename
-            with open(main_branch_schema_path, "r") as f:
-                main_branch_schema_contents = json.load(f)
-            diff = dictdiffer.diff(main_branch_schema_contents, core_model_json)
-            if len(list(diff)) > 0:
-                schemas_that_need_updating.append(core_model)
+            if main_branch_schema_path.exists():
+                with open(main_branch_schema_path, "r") as f:
+                    main_branch_schema_contents = json.load(f)
+                diff = dictdiffer.diff(main_branch_schema_contents, core_model_json)
+                if len(list(diff)) > 0:
+                    schemas_that_need_updating.append(core_model)
         return schemas_that_need_updating
 
     @staticmethod

tests/test_bump_schema_versions.py

@@ -28,9 +28,11 @@ def setUpClass(cls):
 
     @patch("builtins.open")
     @patch("json.load")
-    def test_get_list_of_models_that_changed(self, mock_json_load: MagicMock, _: MagicMock):
+    @patch("pathlib.Path.exists")
+    def test_get_list_of_models_that_changed(self, mock_exists: MagicMock, mock_json_load: MagicMock, _: MagicMock):
         """Tests get_list_of_models_that_changed method."""
         mock_json_load.side_effect = self.mock_open_values
+        mock_exists.return_value = True
 
         handler = SchemaVersionHandler(json_schemas_location=Path("."))
         models_that_changed = handler._get_list_of_models_that_changed()

tests/test_rig_session_compatibility.py

@@ -1,4 +1,5 @@
 """Tests rig session compatibility check"""
+
 import json
 import unittest
 from datetime import date, datetime, timezone