Skip to content

Commit 4e6ee98

Browse files
Fix type signatures to be compatible with pydantic 2.9 (#1053)
* Remove redundant discriminator * Fix type signature and length constrain * Linting * chore: un-capping pydantic version * Revert "chore: un-capping pydantic version" This reverts commit 2f81eda. --------- Co-authored-by: Dan Birman <[email protected]>
1 parent 0104e43 commit 4e6ee98

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

src/aind_data_schema/core/procedures.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -390,10 +390,9 @@ class NonViralMaterial(Reagent):
390390
class Injection(AindModel):
391391
"""Description of an injection procedure"""
392392

393-
injection_materials: Annotated[
394-
List[Union[ViralMaterial, NonViralMaterial]],
395-
Field(title="Injection material", min_length=1, discriminator="material_type"),
396-
]
393+
injection_materials: List[
394+
Annotated[Union[ViralMaterial, NonViralMaterial], Field(..., discriminator="material_type")]
395+
] = Field(..., title="Injection material", min_length=1)
397396
recovery_time: Optional[Decimal] = Field(default=None, title="Recovery time")
398397
recovery_time_unit: TimeUnit = Field(default=TimeUnit.M, title="Recovery time unit")
399398
injection_duration: Optional[Decimal] = Field(default=None, title="Injection duration")

src/aind_data_schema/core/rig.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ class Rig(AindCoreModel):
7777
polygonal_scanners: List[PolygonalScanner] = Field(default=[], title="Polygonal scanners")
7878
pockels_cells: List[PockelsCell] = Field(default=[], title="Pockels cells")
7979
additional_devices: List[Device] = Field(default=[], title="Additional devices")
80-
daqs: List[RIG_DAQ_DEVICES] = Field(default=[], title="Data acquisition devices", discriminator="device_type")
80+
daqs: List[RIG_DAQ_DEVICES] = Field(default=[], title="Data acquisition devices")
8181
calibrations: List[Calibration] = Field(..., title="Full calibration of devices")
8282
ccf_coordinate_transform: Optional[str] = Field(
8383
default=None,

0 commit comments

Comments
 (0)