Merge pull request #80 from AllenNeuralDynamics/fix-null-readparams

Fix edge case where `DataStream[None, None]` was not allowed

Author: bruno-f-cruz

src/contraqctor/contract/base.py

@@ -59,15 +59,15 @@ def __init__(
         name: str,
         *,
         description: Optional[str] = None,
-        reader_params: Optional[_typing.TReaderParams] = None,
+        reader_params: _typing.TReaderParams = _typing.UnsetParams,
         **kwargs,
     ) -> None:
         if "::" in name:
             raise ValueError("Name cannot contain '::' character.")
         self._name = name
 
         self._description = description
-        self._reader_params = reader_params if reader_params is not None else _typing.UnsetParams
+        self._reader_params = reader_params
         self._data = _typing.UnsetData
         self._parent: Optional["DataStream"] = None
 

tests/test_contract/test_core.py

@@ -2,7 +2,7 @@
 from conftest import SimpleDataStream, SimpleParams
 
 from contraqctor import _typing
-from contraqctor.contract.base import DataStreamCollection
+from contraqctor.contract.base import DataStream, DataStreamCollection
 
 
 class TestDataStream:
@@ -88,6 +88,18 @@ def test_clear_data(self, text_file):
         with pytest.raises(ValueError):
             _ = stream.data  # Accessing data after clearing should raise ValueError
 
+    def test_null_data_stream(self):
+        """Test DataStream with None data type."""
+
+        class _NullDataStream(DataStream[None, None]):
+            @staticmethod
+            def _reader(params: None = None) -> None:
+                return None
+
+        null_stream = _NullDataStream(name="null_stream", description="Null data stream", reader_params=None)
+        null_stream.load()
+        assert null_stream.data is None
+
 
 class TestDataStreamCollection:
     """Tests for the DataStreamCollection anonymous class."""