Move errata record creation in dramatiq task #1042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kwaizer
force-pushed
the
errata_creation
branch
10 times, most recently
from
cfaef03 to
204f1c4
Compare
Korulag
approved these changes
Nov 11, 2024
Kwaizer
force-pushed
the
errata_creation
branch
18 times, most recently
from
7bcd132 to
25510db
Compare
Kwaizer
force-pushed
the
errata_creation
branch
4 times, most recently
from
3856279 to
f999ba1
Compare
Korulag
approved these changes
Nov 12, 2024
anfimovdm
requested changes
Nov 12, 2024
Contributor
anfimovdm
left a comment
anfimovdm
left a comment
There was a problem hiding this comment.
Also, please fix the following warnings from the pylint report:
alws/routers/errata.py:1:0: R0401: Cyclic import (alws.dramatiq -> alws.dramatiq.errata) (cyclic-import)
alws/dramatiq/errata.py:22:0: W0311: Bad indentation. Found 5 spaces, expected 4 (bad-indentation)
f999ba1 to
bbb296d
Compare
anfimovdm
approved these changes
Nov 14, 2024
Kwaizer
force-pushed
the
errata_creation
branch
from
bbb296d to
4f22a8e
Compare
tests/test_api/test_errata.py
Outdated
|
|
||
| import pytest | ||
|
|
||
| from alws.dramatiq.errata import create_new_errata |
Member
There was a problem hiding this comment.
Is this import really required here?
Kwaizer
force-pushed
the
errata_creation
branch
from
4f22a8e to
f0a4f1b
Compare
javihernandez
approved these changes
Nov 21, 2024
Kwaizer
force-pushed
the
errata_creation
branch
2 times, most recently
from
dd97401 to
06ca5e5
Compare
anfimovdm
requested changes
Nov 29, 2024
Contributor
anfimovdm
left a comment
anfimovdm
left a comment
There was a problem hiding this comment.
Please fix the following warnings from pylint:
************* Module alws.dramatiq.errata
alws/dramatiq/errata.py:22:0: W0311: Bad indentation. Found 5 spaces, expected 4 (bad-indentation)
************* Module alws.schemas.errata_schema
alws/schemas/errata_schema.py:1:0: R0401: Cyclic import (alws.dramatiq -> alws.dramatiq.errata) (cyclic-import)
68323d0 to
db2ef95
Compare
Contributor
Author
|
@anfimovdm I'm not really sure how this warning can be fixed: Is far as I can understand, we have a cyclic import due to importing functions from |
Contributor
|
@Kwaizer please create an issue for fixing cyclic imports in our code |
Kwaizer
force-pushed
the
errata_creation
branch
from
db2ef95 to
f0a7492
Compare
Kwaizer
force-pushed
the
errata_creation
branch
from
f0a7492 to
af9f319
Compare
Kwaizer
force-pushed
the
errata_creation
branch
from
af9f319 to
8a32544
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: AlmaLinux/build-system#318
create_errata_recordandcreate_new_errata_recordto dramatiq task