Skip to content

Fix cyclic import #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Fix cyclic import #1084

wants to merge 3 commits into from

Conversation

@Kwaizer
Copy link
Contributor

@Kwaizer Kwaizer commented Dec 4, 2024 •
edited
Loading

Resolves: AlmaLinux/build-system#403

  • creating new file and importing event_loop from there

@Kwaizer Kwaizer force-pushed the cyclic branch 5 times, most recently from 3423bb1 to b708c09 Compare December 4, 2024 13:26
@anfimovdm
Copy link
Contributor

anfimovdm commented Dec 4, 2024

That didn't help, it's probably because of importing things in alws/dramatiq/__init__.py

pylint alws/

alws/middlewares/__init__.py:1:0: R0401: Cyclic import (alws.crud.release -> alws.release_planner -> alws.crud.sign_task -> alws.crud.user -> alws.dramatiq -> alws.dramatiq.releases) (cyclic-import)
alws/middlewares/__init__.py:1:0: R0401: Cyclic import (alws.crud.build -> alws.dramatiq -> alws.dramatiq.user) (cyclic-import)
alws/middlewares/__init__.py:1:0: R0401: Cyclic import (alws.crud.sign_task -> alws.crud.user -> alws.dramatiq -> alws.dramatiq.sign_task) (cyclic-import)
alws/middlewares/__init__.py:1:0: R0401: Cyclic import (alws.crud.products -> alws.crud.teams -> alws.crud.user -> alws.dramatiq -> alws.dramatiq.releases -> alws.crud.release -> alws.release_planner) (cyclic-import)
alws/middlewares/__init__.py:1:0: R0401: Cyclic import (alws.crud.products -> alws.dramatiq -> alws.dramatiq.releases -> alws.crud.release -> alws.release_planner) (cyclic-import)
alws/middlewares/__init__.py:1:0: R0401: Cyclic import (alws.crud.products -> alws.crud.user -> alws.dramatiq -> alws.dramatiq.releases -> alws.crud.release -> alws.release_planner) (cyclic-import)

@Kwaizer
Copy link
Contributor Author

Kwaizer commented Dec 4, 2024 •
edited
Loading

@anfimovdm how did you check this?

@anfimovdm anfimovdm marked this pull request as draft December 10, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix cyclic imports

2 participants

@Kwaizer @anfimovdm