Skip to content

Conversation

@Kwaizer
Copy link
Contributor

@Kwaizer Kwaizer commented Jun 17, 2025

Copy link
Contributor

@bklvsky bklvsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move sentry_sdk.init() to albs.dramatiq.init.py file so that the code isn't duplicated across all actors?

@Kwaizer
Copy link
Contributor Author

Kwaizer commented Jun 17, 2025

Can we move sentry_sdk.init() to albs.dramatiq.init.py file so that the code isn't duplicated across all actors?

@bklvsky Yes, I had troubles with circular import here last time, but it seems fine for this one

Copy link
Contributor

@bklvsky bklvsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@javihernandez javihernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of recommendations for better git commit messages from our commit guidelines:

  • The reference to the issue being resolved should be mentioned (if any) in the first commit message
  • "Remove duplication" as a commit message can be a bit ambiguous. You could probably add some more meaningful commit message like "Remove sentry setup duplication" or "Remove sentry setup duplication in task queues". Up to you.

If you want to fix the commit messages, you can, from your current sentry-dramatiq branch, do the following:

  1. git format-patch HEAD^^ # this will generate 2 patches
  2. git reset HEAD^^ --hard # this will reset your branch (and reset staged changes)
  3. At this point, you can either:
  • update your two patches directly to fix the commit messages. And then git am both patches
  • git am the first patch, do a git commit --amend and fix the commit message. repeat for the second one
  1. git push <your_origin_name> sentry-dramatiq --force to update your branch with fixed commits

@Kwaizer Kwaizer force-pushed the sentry-dramatiq branch 2 times, most recently from 979e6c8 to ef542dc Compare June 18, 2025 12:52
@anfimovdm anfimovdm merged commit 7c88438 into AlmaLinux:master Jun 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add sentry to our task queues

4 participants