Compress test logs before sending them to the web server#117
Merged
Conversation
anfimovdm
force-pushed
the
add_logs_compression
branch
2 times, most recently
from
03c02f7 to
69d40e0
Compare
anfimovdm
force-pushed
the
add_logs_compression
branch
from
69d40e0 to
7ee1368
Compare
anfimovdm
force-pushed
the
add_logs_compression
branch
from
7ee1368 to
96acdfb
Compare
anfimovdm
force-pushed
the
add_logs_compression
branch
from
96acdfb to
6ca8639
Compare
maccelf
approved these changes
Feb 17, 2025
|
|
||
|
|
||
| def wait_bg_process(future: Future, timeout: int): | ||
| # For some reason, plumbum.commands.modifiers.Future.wait method |
Member
There was a problem hiding this comment.
Hm, interesting. Which version of plumbum? I'm on 1.8.2 and everything looks fine here, see:
>>> runner = ( local['tail'].with_env(FOO='bar').run_bg(args=['-f', '/dev/null'], timeout=2, retcode=None,) )
>>> runner.wait()
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/jhernandez/sandbox/python/paramiko/env/lib64/python3.10/site-packages/plumbum/commands/modifiers.py", line 43, in wait
self._returncode, self._stdout, self._stderr = run_proc(
File "/home/jhernandez/sandbox/python/paramiko/env/lib64/python3.10/site-packages/plumbum/commands/processes.py", line 299, in run_proc
return _check_process(proc, retcode, timeout, stdout, stderr)
File "/home/jhernandez/sandbox/python/paramiko/env/lib64/python3.10/site-packages/plumbum/commands/processes.py", line 17, in _check_process
proc.verify(retcode, timeout, stdout, stderr)
File "/home/jhernandez/sandbox/python/paramiko/env/lib64/python3.10/site-packages/plumbum/machines/base.py", line 15, in verify
raise ProcessTimedOut(
plumbum.commands.processes.ProcessTimedOut: ('Process did not terminate within 2 seconds', ['/usr/bin/tail', '-f', '/dev/null'])
Contributor
Author
There was a problem hiding this comment.
Yes, it works in that way, but when you're trying to run a background process in celery or multiprocessing.Pool run_bg doesn't take timeout into account
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.