Skip to content

Add builds for PRs #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hanthor wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add builds for PRs #20

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
afde629
fix: update workflow triggers for pull requests and pushes to main
hanthor May 29, 2025
5fa2813
Update build.yml to remove on push
hanthor May 29, 2025
9676117
fix: update Run Image step to use container lint command and adjust c…
hanthor May 29, 2025
d117b39
Update build.yml to not push manifest on PR
hanthor May 29, 2025
294bc0b
Merge branch 'main' into PR-build-checks
hanthor May 31, 2025
0ef4f92
Update action.yml to remove fatal warnings
hanthor May 31, 2025
fa8a618
Merge branch 'main' into PR-build-checks
hanthor May 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/actions/shared-steps/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,15 @@ runs:
- name: Run Image
if: ${{ env.res != 0 || github.event_name == 'workflow_dispatch' }}
shell: bash
run: sudo podman run --rm -ti ${{ env.IMAGE_NAME }} bootc --version
run: sudo podman run --rm -ti ${{ env.IMAGE_NAME }} bootc container lint --fatal-warnings
Copy link
Member Author

@hanthor hanthor May 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about the use of --fatal-warnings if it will cause things to fail that should pass.

Copy link
Contributor

@imbev imbev May 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Containerfiles already contain linting, so that can be removed here or there.

Our disregard of the lint warnings hasn't caused major problems yet, so I think we can keep it non-fatal for now. Eventually it may be useful to enable the fatal warnings.


- name: Log in to registry
if: ${{ env.res != 0 || github.event_name == 'workflow_dispatch' }}
if: ${{ (env.res != 0 || github.event_name == 'workflow_dispatch') && github.event_name != 'pull_request' }}
shell: bash
run: sudo podman login ${{ inputs.IMAGE_REGISTRY }} -u ${{ inputs.REGISTRY_USER }} -p ${{ inputs.REGISTRY_PASSWORD }}

- name: Push to registry
if: ${{ env.res != 0 || github.event_name == 'workflow_dispatch' }}
if: ${{ (env.res != 0 || github.event_name == 'workflow_dispatch') && github.event_name != 'pull_request' }}
shell: bash
run: |
# Tag: VERSION_MAJOR.VERSION_MINOR-DATE_STAMP-ARCH
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ jobs:
password: ${{ secrets.REGISTRY_PASSWORD }}

- name: Create and push manifest (docker)
if: github.event_name != 'pull_request'
run: |
# Manifest for both amd64 and arm64
IMAGE_DEST=${{ secrets.IMAGE_REGISTRY }}/${{ env.IMAGE_NAME }}
Expand Down