Standardize continent names #1281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The continent field is not necessary at all...and I actually plan to get rid of it. We can derive it from the country. It's just be a low-priority thing to clean up. |
jonathanspw
approved these changes
Oct 7, 2025
Member
|
I expect CI to fail. Some mirrors are missing their |
Member
|
A blank state_province should've been valid. Were you having to fill them in to get CI to pass? |
Member
Author
|
No, Copilot just got carried away and I let it do its thing. :P |
Member
|
Want to squash the commits to keep git history cleaner? |
Member
|
Commits are un-squashed again. PS - next time update with rebase instead of merge to keep it rebased ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started as me adding the continent to the CERN mirror, then it escalated to fixing all the European mirrors, and then it just got out of hand. Don't judge me.