Refactor: Only source ls-colors.zsh when fzftab module isn't loaded #555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
fzf-tab sources
lib/zsh-ls-colors/ls-colors.zshunconditionally. However, when thealoxaf/fzftabmodule is present and successfully loaded, filename coloring is performed directly by zsh through the module, so sourcingls-colors.zshis redundant.What this PR does
FZF_TAB_MODULE_VERSIONat init to avoid stale values influencing the logic.aloxaf/fzftab(and keeps the existing rebuild/version-check logic).ls-colors.zshonly if the module is not available or fails to load.Result
No behavior change for users without the module; less work at startup for users with a working
aloxaf/fzftabmodule.