added HeroDevelopmentPage and HeroMenuAsDropdown #308
Conversation
| import darkBlue from '@/shared/assets/images/heros/textBgColors/dark-blue_cropped.webp'; | ||
| import purpleBg from '@/shared/assets/images/heros/textBgColors/purple.webp'; | ||
| import { GroupInfo, HeroGroup, HeroSlug } from '../types/hero'; | ||
| import { statData } from '@/entities/Hero/model/stats/statsDataV2'; |
There was a problem hiding this comment.
should be "@/entities/Hero" according to https://feature-sliced.design/
| import { statsPricingData } from '../../model/stats/statsPricingData'; | ||
| import { AttributePricingHelper } from '../../model/stats/AttributesPricingHelper'; | ||
| import cls from './AttributesPricing.module.scss'; | ||
| import { statValue } from '@/entities/Hero/model/stats/statsDataV2'; |
There was a problem hiding this comment.
should be "@/entities/Hero" according to https://feature-sliced.design/
| import userEvent from '@testing-library/user-event'; | ||
| import { useClientTranslation } from '@/shared/i18n'; | ||
| import { HeroSlug } from '@/entities/Hero'; | ||
| import HeroMenuAsDropdown from '@/features/NavigateHeroes/ui/HeroMenuAsDropdown'; |
There was a problem hiding this comment.
instead "import HeroMenuAsDropdown from '@/features/NavigateHeroes/ui/HeroMenuAsDropdown';" should be "./HeroMenuAsDropdown"
| import cls from './HeroDevelopmentPage.module.scss'; | ||
| import { HeroManager, AttributesPie } from '@/entities/Hero'; | ||
| import { HeroWithGroup, HeroSlug, Stat } from '@/entities/Hero/types/hero'; | ||
| import { BarChart } from '@/entities/Hero/ui/BarChart/BarChart'; |
There was a problem hiding this comment.
should be "@/entities/Hero" according to https://feature-sliced.design/
| import Image from 'next/image'; | ||
| import cls from './HeroDevelopmentPage.module.scss'; | ||
| import { HeroManager, AttributesPie } from '@/entities/Hero'; | ||
| import { HeroWithGroup, HeroSlug, Stat } from '@/entities/Hero/types/hero'; |
There was a problem hiding this comment.
should be "@/entities/Hero" according to https://feature-sliced.design/
| import { HeroManager, AttributesPie } from '@/entities/Hero'; | ||
| import { HeroWithGroup, HeroSlug, Stat } from '@/entities/Hero/types/hero'; | ||
| import { BarChart } from '@/entities/Hero/ui/BarChart/BarChart'; | ||
| import { color, rarityClassNames } from '@/entities/Hero/model/stats/statsDataV2'; |
There was a problem hiding this comment.
should be "@/entities/Hero" according to https://feature-sliced.design/
| import { HeroWithGroup, HeroSlug, Stat } from '@/entities/Hero/types/hero'; | ||
| import { BarChart } from '@/entities/Hero/ui/BarChart/BarChart'; | ||
| import { color, rarityClassNames } from '@/entities/Hero/model/stats/statsDataV2'; | ||
| import { statsPricingData } from '@/entities/Hero/model/stats/statsPricingData'; |
There was a problem hiding this comment.
should be "@/entities/Hero" according to https://feature-sliced.design/
| import { useClientTranslation } from '@/shared/i18n'; | ||
| import useSizes from '@/shared/lib/hooks/useSizes'; | ||
| import { classNames, Mods } from '@/shared/lib/classNames/classNames'; | ||
| import { AttributesPricing3 } from '@/entities/Hero/ui/AttributesPricing3/AttributesPricingV3'; |
There was a problem hiding this comment.
should be "@/entities/Hero" according to https://feature-sliced.design/
| import useSizes from '@/shared/lib/hooks/useSizes'; | ||
| import { classNames, Mods } from '@/shared/lib/classNames/classNames'; | ||
| import { AttributesPricing3 } from '@/entities/Hero/ui/AttributesPricing3/AttributesPricingV3'; | ||
| import HeroMenuAsDropdown from '@/features/NavigateHeroes/ui/HeroMenuAsDropdown'; |
There was a problem hiding this comment.
should be "@/features/NavigateHeroes" according to https://feature-sliced.design/
|
|
# Conflicts: # frontend-next-migration/src/shared/ui/DropdownWrapper/ui/DropdownWrapper.tsx
📄 Pull Request Overview
Added HeroDevelopmentPage and its associated HeroMenuAsDropdown, which differs from the HeroNavMenuAsDropdown component, where the routing logic has been replaced with a callback function. The hero selected from the dropdown is set as the state of HeroDevelopmentPage. The component also has states adjusted by the AttributesPricing component. These states control the content displayed within HeroDevelopmentPage.
closes #280
🔧 Changes Made
Added initializeHeroGroups hero-specific stat data.
✅ Checklist Before Submission
console.log()or other debugging statements are left.Removed AttributesPricing.test.tsx. The AttributesPricing component has been modified to adjust external states, making it no longer testable as an isolated unit.
📝 Additional Information
Provide any additional context or information that reviewers may need to know:
Warning: Cannot update a component (
HeroDevelopmentPage) while rendering a different component (AttributesPricing3)