-
Notifications
You must be signed in to change notification settings - Fork 2
Custom select menu for LangSwitcher #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Chromoprotein is this a new PR? Did you do requested changes from the last one? |
|
@Skoivumaki Yes, sorry I made a new branch and PR because I had some git problems. I made the requested changes except the animation. Is it ok if that's a separate issue? |
|
@Chromoprotein Did you figure out the ident issue?
Maybe if needed |
|
@Skoivumaki I noticed the mobile version was making the logout button's text next to it look misaligned, so I fixed that, but I'm not sure that was the problem tbh. |
|
|
@leolabdev clarification about the ident thing? |
|
@Skoivumaki @Chromoprotein VSAlso, on the browser solution, you can see that the option and label are on the same level and aligned to the left. I think we should also stick to this. Also, now when hovering over it, this is not shown to the user at all. |
leolabdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comments above
7732394 to
5bc139c
Compare
Jonroi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@leolabdev It looks like this can't be merged until you approve it, could you please review? 🙂 |








📄 Pull Request Overview
closes 211
🔧 Changes Made
Made a custom drop-down select menu for switching languages.
Added the requested style improvements: aligned the text to left, made the arrow smaller with more spacing, improved the border's style cohesion, and made the mobile version look cleaner.
✅ Checklist Before Submission
console.log()or other debugging statements are left.📝 Additional Information