Jarno/enhancement/131-team-page-enhancement-3 #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ged logo to partially go off-screen on some screen sizes
Member
|
@Rutjake Does this work well on mobile phones too? |
Contributor
Author
|
I can only test it in a simulation (browser) because the data retrieval doesn't work if I test it on my phone for some reason. Responsiveness works in the browser. |
Skoivumaki
requested changes
Dec 12, 2024
Member
Skoivumaki
left a comment
Skoivumaki
left a comment
There was a problem hiding this comment.
Logos are way too small when enlargened on mobile devices, tablet and desktop are fine.
Maybe 2x or 3x logo size on small devices?
Very intresting choice of resolution and crop on your example videos :D
leolabdev
approved these changes
Dec 12, 2024
Member
|
@Rutjake @Skoivumaki I had to merge (since they want the update before 18.12), but you can continue working on this branch. Also, consider adjusting the spacing between texts, headings, and so on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Team member logos will enlarge when clicked and return to their original size when clicked again.
Added media query for smaller screens (padding) to avoid the enlarged logo going partially off screen.
The text in the member task section has been made slightly smaller for better visibility.
closes 131
🔧 Changes Made
[Briefly describe changes you made]
Added useState for click handling and added css rules for text and logo
[Any refactoring or clean-up tasks]
✅ Checklist Before Submission
console.log()or other debugging statements are left.📝 Additional Information
Provide any additional context or information that reviewers may need to know:
Desktop_Teampage.mp4
Mobile_TeamPage.mp4
Implementing Directus changed the page layout for some reason. So it may be necessary to make a new issue for adjusting the text spacing vertically to clarify the content on the page. Not included in this issue and may require larger changes elsewhere in the code.