-
Notifications
You must be signed in to change notification settings - Fork 2
Jarno/feature/298-responsive-flexbox-layout-for-clans-main-page #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jarno/feature/298-responsive-flexbox-layout-for-clans-main-page #311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build is failing because of a typo. import './ClanPageLayout.scss'; when it should be import './clanPageLayout.scss'; but change the file name to keep good practice: ClanPageLayout.scss
We dont store CSS inside [lng], code for layout should be stored inside pages layer and should only be imported in [lng]. (see Auth for example: [lng](helper)\auth\layout.tsx) We have a place to store layouts but since this layout is Clan specific I think this will do for now.

About FSD folder scheme: https://feature-sliced.design
To summarize:
- Rename
clanPageLayout.scsstoClanPageLayout.scss - Move code related to layout to proper location
- Dont override the old layout yet, since it may break some clan elements.
- Make sure build and tests pass
|
@Skoivumaki @Rutjake Hey guys, we use CSS (SCSS) modules, not plain CSS. |
Skoivumaki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works as expected. Only thing missing was the export in index.ts for the layout itself, but I added that myself.
leolabdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jonroi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read the latest comments from the reviewers and noted that the breakpoints have been used correctly and the previous tasks have been completed, so good work
Skoivumaki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above

📄 Pull Request Overview
closes 298
🔧 Changes Made
Created flexboxes for the page layout (lng\clans\layout.tsx) and adjusted responsiveness and alignment in the CSS file (new file, ClanPageLayout.scss).
✅ Checklist Before Submission
Responsiveness worked in the browser and the flexbox size was adjusted according to the page's main menu.
📝 Additional Information
Provide any additional context or information that reviewers may need to know: