Skip to content

Conversation

@Smai00
Copy link
Contributor

@Smai00 Smai00 commented Dec 17, 2024

πŸ“„ Pull Request Overview

closes #303

πŸ”§ Changes Made

Added an API endpoint getLeaderboard for retrieving leaderboard data.


βœ… Checklist Before Submission

  • Functionality: I have tested my code, and it works as expected.
  • JSDoc: I have added or updated JSDoc comments for all relevant code.
  • Debugging: No console.log() or other debugging statements are left.
  • Clean Code: Removed commented-out or unnecessary code.
  • Tests: Added new tests or updated existing ones for the changes made.
  • Documentation: Documentation has been updated (if applicable).

πŸ“ Additional Information

Provide any additional context or information that reviewers may need to know:

  • Screenshots: [Include any screenshots or videos if the changes affect the UI]
  • Dependencies: [Mention any new dependencies or breaking changes]
  • Known Issues: [List any known issues or limitations]

@Skoivumaki
Copy link
Member

Skoivumaki commented Dec 18, 2024

Build most likely failing because of changes to following files:
frontend-next-migration/.husky/pre-commit
frontend-next-migration/package-lock.json
These changes should be ignored when merging.
Husky was developing issues on client side when commiting to Github.

@Skoivumaki
Copy link
Member

Keep on HOLD until this problem is figured out.

@Skoivumaki Skoivumaki added this to the Clans milestone Dec 18, 2024
@leolabdev
Copy link
Member

why are you trying to delete one of the most important files ? πŸ˜…

@Skoivumaki
Copy link
Member

why are you trying to delete one of the most important files ? πŸ˜…

I was planning to redo this issue, Rami no longer works on this project.

@Skoivumaki
Copy link
Member

#347 closes this PR

@Skoivumaki Skoivumaki closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants