Conversation
Skoivumaki
reviewed
Nov 19, 2025
...-next-migration/src/preparedPages/EthicalGuidelinesPage/ui/EthicalGuidelinesPage.module.scss
Outdated
Show resolved
Hide resolved
Member
|
Apparently review message didnt go through. You dont need to update/create stories or tests. You can simply disable/remove them. |
Skoivumaki
approved these changes
Nov 29, 2025
Member
Skoivumaki
left a comment
There was a problem hiding this comment.
Issues resolved. Good work 👍
Rutjake
approved these changes
Dec 1, 2025
Contributor
Rutjake
left a comment
There was a problem hiding this comment.
Good work. I noticed that the page-specific mobile menu is missing, but it hasn't been done in Figma either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Pull Request Overview
Closes #598
New Ethical Guidelines page, using the existing Privacy/Cookies architecture to ensure consistency across all informational pages.
🔧 Changes Made
1. Implemented new Ethical Guidelines page
/ethical-guidelineswith localized version/[lng]/ethical-guidelinespreparedPages/EthicalGuidelinesPage_getPage.ts,page.tsx, andloading.tsxunderapp/[lng]/(helper)/ethical-guidelinesEthicalGuidelinesSectionsandmakeEthicalGuidelinesSectionsWithI18nusing existing PresentationPackages structure2. Added i18n support (Finnish & English)
ethics.jsonfor both languages3. SEO & Metadata
4. Added footer link
Rights.tsx, styles, Storybook stories, and Jest tests✅ Checklist Before Submission
console.log()or other debugging statements are left.📝 Additional Information
UI Notes
Screenshots
Desktop:
Mobile:
Footer: