Skip to content

Nikolas/feature/598 implement new ethical ethical guidelines page#599

Merged
Rutjake merged 8 commits intodevfrom
nikolas/feature/598-implement-new-ethical-ethical-guidelines-page
Dec 1, 2025
Merged

Nikolas/feature/598 implement new ethical ethical guidelines page#599
Rutjake merged 8 commits intodevfrom
nikolas/feature/598-implement-new-ethical-ethical-guidelines-page

Conversation

@NikolasKataja
Copy link
Contributor

📄 Pull Request Overview

Closes #598

New Ethical Guidelines page, using the existing Privacy/Cookies architecture to ensure consistency across all informational pages.

🔧 Changes Made

1. Implemented new Ethical Guidelines page

  • Added new route /ethical-guidelines with localized version /[lng]/ethical-guidelines
  • Created new prepared page under preparedPages/EthicalGuidelinesPage
  • Added _getPage.ts, page.tsx, and loading.tsx under app/[lng]/(helper)/ethical-guidelines
  • Implemented EthicalGuidelinesSections and makeEthicalGuidelinesSectionsWithI18n using existing PresentationPackages structure

2. Added i18n support (Finnish & English)

  • Added ethics.json for both languages
  • Includes all content, sidebar titles, page title, SEO metadata (title, description, keywords, OG tags)

3. SEO & Metadata

  • Added page title, description, keywords, canonical URL, and OpenGraph
  • Ensures SEO parity with Privacy & Cookies pages

4. Added footer link

  • Footer now also includes link to Ethical Guidelines page
  • Updated Rights.tsx, styles, Storybook stories, and Jest tests
  • Ensured the new link behaves consistently with existing “Privacy” and “Cookies” links (hover and layout)

Checklist Before Submission

  • Functionality: I have tested my code, and it works as expected.
  • JSDoc: I have added or updated JSDoc comments for all relevant code.
  • Debugging: No console.log() or other debugging statements are left.
  • Clean Code: Removed commented-out or unnecessary code.
  • Tests: Added new tests or updated existing ones for the changes made.
  • Documentation: Documentation has been updated (if applicable).

📝 Additional Information

UI Notes

  • Figma design showed a single-column layout, but I understood the issue as explicitly requesting the same section-based architecture as the Cookies/Privacy pages
  • I chose to follow the existing section layout to maintain UX consistency across all informational pages

Screenshots

Desktop:

Ethical Guidelines Desktop

Mobile:

Ethical Guidelines Mobile

Footer:

Footer Ethics Link

@Skoivumaki
Copy link
Member

Apparently review message didnt go through. You dont need to update/create stories or tests. You can simply disable/remove them.
Other than that, code looks clean and professional.
Note: Didnt review in IDE.

Copy link
Member

@Skoivumaki Skoivumaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues resolved. Good work 👍

Copy link
Contributor

@Rutjake Rutjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. I noticed that the page-specific mobile menu is missing, but it hasn't been done in Figma either.

@Rutjake Rutjake merged commit 28c29c8 into dev Dec 1, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in altzone-webpages Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants