Eleino/enhancement/596 update news card and single newspage rendering logic#601
Merged
Skoivumaki merged 5 commits intodevfrom Dec 8, 2025
Conversation
eleino
requested review from
Rutjake,
Skoivumaki,
kaisahakola,
leolabdev and
patinen
as code owners
Skoivumaki
requested changes
Nov 24, 2025
Member
Skoivumaki
left a comment
Skoivumaki
left a comment
There was a problem hiding this comment.
Good work! Nice to see the additional "error catches" you have implemented for edge-case scenarios.
- Not part of the issue but, could you change the news text to be aligned from the left instead of center. (its Figma Design and I believe it will make text more readable)
- Still not part of the issue: Please slightly increase the
line-heightof text inNewsElementPagetext/pand decrease container width for desktop devices. (likewidth: 80%and test on all devices) - Change
noImageContainerclassheightto2vhor similar to remove the odd padding. (test on all devices to ensure it looks good) Example with these changes on right:
…rea, and slightly increased line height of the text
Skoivumaki
requested changes
Nov 29, 2025
| text-align: center; | ||
| width: 100%; | ||
| text-align: left; | ||
| width: 80%; |
Member
There was a problem hiding this comment.
Add breakpoint to keep width: 98% (to add very slight padding) on mobile and PR is good 👍
Skoivumaki
approved these changes
Dec 4, 2025
Rutjake
approved these changes
Dec 5, 2025
Contributor
Rutjake
left a comment
Rutjake
left a comment
There was a problem hiding this comment.
Great job! The news items without a picture look much better now.
I won't merge this yet because I need to make some minor changes unrelated to the issue.
Restores lost SEO codes related to conflicting merges or accidental deletions on GitHub, specifically: - **Restores** enhanced news and gallery page rendering logic. - **Improves/Restores** SEO metadata handling (titles, descriptions, keywords). - **Refactors** Open Graph image retrieval and URL formatting for better social sharing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Pull Request Overview
Closes #596
🔧 Changes Made
✅ Checklist Before Submission
console.log()or other debugging statements are left.📝 Additional Information
Provide any additional context or information that reviewers may need to know: