Updated AvatarEditor #1165

tomipir · 2025-12-19T13:01:12Z

Replaced the current page/book style categorization with a sideways scrolling bar

Bar has items in two rows
Selected item is highligted
Owned pieces are sorted to the left side of the scroll

Replaced category selection with a vertical scroll that shows 3 items at a time

Scrolling is infinite
After letting go of the scroll, the category closest to the middle is selected
Category image is the first image of the category, default images for categories should propably be added later

Added color selection visually

Functionality not implemented yet

Added a speech bubble that shows a random phrase listed in the GDD when opening AvatarEditor

Added a confirmation popup window for saving

Left old scripts in the files if needed for reference in the near future

Known Issues

Opening AvatarEditor with the confluent/symbiosis class gives an error. Editor still works as expected
Opening AvatarEditor gives a warning about a color that could not be parsed, and uses the default white color
Popup window buttons don't scale properly with aspect ratio
Changing aspect ratio while the game is running doesn't update cell sizes
Sometimes when clicking different features really fast the input doesn't register until you click somewhere else
Text for the speech bubbles in popup and AvatarEditor windows is not localized
Some features look really small. This will likely be fixed automatically when each featureimage has a correct iconimage set
When opening AvatarEditor for the first time after launching the game, the default character image is shown for a few frames

- Hardcoded to hair atm

attached script to HorizontalScrollView-Grid instead of BottomMenu

- Added VerticalScrollViewGrid for category selection - renamed ScrollBarContentLoader script to ScrollBarFeatureLoader

- Also removed placeholder images from verticalscroll

VerticalScrollView-Grid => CategoryGrid HorizontalScrollView-Grid => FeatureGrid

- Clicking features on FeatureGrid now updates the character - Made SetFeature function from FeaturePicker public to bypass old logic - Feature slot that's being changed hardcoded to hair for now - Made BookImage transparent in editor to see more easily

- Now changing the category works - Feature category Id:s being hardcoded is not optimal, returning to it later

- Added LayoutElement component to prefab - Replaced many CategoryGrid components - Added UpdateCellSize function Category selection now shows 3 categories regardless of screen size/aspect ratio. It does not update when changing screen size while the app is running for now.

Not sure if OnEndDrag is the right event yet

- It now clicks the button on the cell after clamping - Clicking the cells still works too, planning on changing this later

- Now there are cells now both top and bottom when loading the grid items

- Renamed wrongly named variable - Made CategoryGrid create 3 of each category for future purposes

Body part was in hair category

BillTheBeast · 2026-01-07T09:19:00Z

Assets/MenuUi/Scripts/AvatarEditor/CategoryScrollClampController.cs

+
+            float t = 0f;
+
+            while (t < 1)


Vähän epäselvä toteutus, vaikka onkin tarpeellinen. Ymmärrän että tämän on tarkoitus tapahtua 0,2 sekunnissa ja sen takia toi kertominen 5:llä, mut kannattaa varmaankin kirjoittaa kommentti tähän siitä.

Kirjoitin selkeämmäksi

BillTheBeast · 2026-01-07T09:34:02Z

Assets/MenuUi/Scripts/AvatarEditor/CategoryScrollClampController.cs

+
+        private void OnClamp(float targetYPos)
+        {
+            float totalCellSize = _categoryLoader.cellHeight + _categoryLoader.spacing;


Tämä sama laskuhan tehdään tossa ClampToCenterissä, voisiko tuon indeksin antaa sieltä.

Tehty. Lisäsin myös sen että dragin aloittaminen lopettaa jo käynnissä olevan clamppauksen

BillTheBeast · 2026-01-07T09:35:23Z

Assets/MenuUi/Scripts/AvatarEditor/ColorGridLoader.cs

+            GameObject colorGridCell = Instantiate(_gridCellPrefab, _colorGridContent);
+            GridCellHandler handler = colorGridCell.GetComponent<GridCellHandler>();
+
+            Vector2 colorImageMinAnchors = new(0.05f, 0.05f);


Nimeämis säännöt. Toinen on kirjoitettu isolla, toinen pienellä.

BillTheBeast · 2026-01-07T09:42:30Z

Assets/MenuUi/Scripts/AvatarEditor/ColorGridLoader.cs

+            }
+        }
+
+        private void AddListener()


Kannattaa kirjoittaa kommentti, jos koodi on keskeneräinen. (Erottaa onko jotain mitä on tulossa myöhemmin vai että onko vahingossa lisätty/jäänyt.)

Tehty. Pidetään mielessä jatkossa.

BillTheBeast · 2026-01-07T09:50:23Z

Assets/MenuUi/Scripts/AvatarEditor/FeatureSetter.cs

+        public string GetSelectedFeature(int index) =>
+            index >= 0 && index < _selectedFeatures.Count ? _selectedFeatures[index] : null;
+
+        public void SetSelectedFeature(int index, string value)


Muuttaisin nämä metodit niin, että ne on yksityisiä ja sit vain lisäisin uudet julkiset, joille annetaan suoraan toi AvatarPiece enum, joka kertoo mikä pala pitäisi olla käytössä.

Laitoin yksityiseksi. En tehnyt uusia julkisia kun niitä ei tällä hetkellä käytetä missään muualla

BillTheBeast · 2026-01-07T09:52:11Z

Assets/MenuUi/Scripts/AvatarEditor/FeatureSetter.cs

+                _selectedFeatures[index] = value;
+        }
+
+        public List<AvatarPartInfo> GetCurrentCategoryFeatures() => _currentCategoryFeatures;


Tarvitseeko näitä metodeita (ja samoin että onko toi _currentCategoryFeatures tarpeellinen)?

Ei tarvitse, poistin paljon muutakin käyttämätöntä mitä oli jäänyt vanhasta koodista

BillTheBeast · 2026-01-07T09:54:03Z

Assets/MenuUi/Scripts/AvatarEditor/FeatureSetter.cs

+        [SerializeField] private AvatarPartsReference _avatarPartsReference;
+        private List<string> _selectedFeatures = new List<string>(new string[7]);
+        private List<AvatarPartInfo> _currentCategoryFeatures = new();
+        private CharacterClassType _characterClassType;


Tarvitseeko hahmon luokan tietoja olla tässä metodissa? Nehän saa muualta jos tarvitsee.

Ei tarvitse, oli jäänyt vahingossa

BillTheBeast · 2026-01-07T10:15:01Z

Assets/MenuUi/Scripts/AvatarEditor/GridCellHandler.cs

+        [SerializeField] private Image _featureImage;
+        [SerializeField] private Button _button;
+
+        public void SetValues(Sprite cellImage = null,


Suosittlen uudelleen järjestämään nämä muuttujat sillä, esim. toi cellImagen värin oleminen viimeisenä kun taas toi cellImage on ensimmäinen haittaa hieman luettavuutta.

Lisäksi kannattaa kysyä pitäisikö, joku tieto pistää pakolliseksi ettei päädy käyttämään metodia ilman muuttujia.

Järjestin uudelleen. Mitään tiettyä tietoa en laittanut pakolliseksi koska ei ole yhtä tiettyä mitä käytän aina, mutta antaa nyt varoituksen eikä tee mitään jos metodi kutsutaan ilman muuttujia.

BillTheBeast · 2026-01-07T11:46:59Z

Assets/MenuUi/Scripts/AvatarEditor/ScrollBarFeatureLoader.cs

+        {
+            if (_selectedCellHandler != null)
+            {
+                _selectedCellHandler.SetValues(backgroundColor: _backgroundColor);


Voisiko nämä arvot antaa Handlerille tuossa kun se luodaan ja sitten vain käskeä sitä vaihtaa niitä edestakaisin tarpeen mukaan.

-Removed double index calculation -Made while loop more clear to read -Coroutine now stops if you click again before it has finished

Made anchors not exceed value 1 or be less than 0

-Clicking the category cells now selects them in addition to dragging -Bugs out if you go in same direction a few times, need to rethink infinitescroll

-Buttons now disabled until the animation finishes -Now loops correctly when only clicking buttons

-Now no longer goes beyond the given screen space

-Now shows a warning and does nothing if called without no arguments

-Set functions not needed elsewhere private

-Made own scrips for featurecell, categorycell and colorcell that inherift from gridcellhandler -Made each its own prefab -Adjusted scripts to work with these changes

tomipir added 30 commits December 4, 2025 14:05

Added bottomMenu and HorizontalScrollView-Grid

7dc82a8

Added HorizontaScrollView-Grid with test content

d3bbfb9

moved old editor window out of the way without removing it

b5bb2d4

Added prefab for cell and test script

c357333

Changed GridCell prefab image opacity to full

16aeb1a

Deleted placeholder content in grid

2ba3d4f

Made grid get real avatarparts

9029131

- Hardcoded to hair atm

Changed ScrollBarContentLoader script object

f89216b

attached script to HorizontalScrollView-Grid instead of BottomMenu

Added VerticalScrollViewGrid and renamed script

14244bf

- Added VerticalScrollViewGrid for category selection - renamed ScrollBarContentLoader script to ScrollBarFeatureLoader

Changed VerticalScrollViewGrid settings

bf7c03f

added script ScrollBarCategoryLoader

4d813d7

added script and components to verticallscrollview-grid

9dbc782

Modified script to check if scrollbar works

3e7d5af

- Also removed placeholder images from verticalscroll

added empty cells to the top and bottom of verticalscrollbar

bf7f5d0

Moved loading featurelistitems to its own function

9a30522

Added function DestroyFeatureListItems to clear the feature list

167132d

Added button to gridcell prefab

bf62611

updated scrollbarecategoryloader

770cc16

added listeners to change featurelist when clicking category

47c5f68

Changed grid names to be more descriptive

406a316

VerticalScrollView-Grid => CategoryGrid HorizontalScrollView-Grid => FeatureGrid

Comments and refactoring

7633087

Removed test cells and renamed function

de32352

Updated FeatureGrid

b793a06

- Clicking features on FeatureGrid now updates the character - Made SetFeature function from FeaturePicker public to bypass old logic - Feature slot that's being changed hardcoded to hair for now - Made BookImage transparent in editor to see more easily

Updated FeatureGrid

53b47e6

- Now changing the category works - Feature category Id:s being hardcoded is not optimal, returning to it later

Fixed padding on CategoryGrid

ed18e37

CategoryGrid now clamps to center

1a03a5a

Not sure if OnEndDrag is the right event yet

Updated CategoryGrid

5602e57

- It now clicks the button on the cell after clamping - Clicking the cells still works too, planning on changing this later

Updated FeatureGrid

4c0d982

- Now there are cells now both top and bottom when loading the grid items

updated CategoryGrid

4c1e56a

- Renamed wrongly named variable - Made CategoryGrid create 3 of each category for future purposes

tomipir self-assigned this Dec 19, 2025

tomipir added the käyttöliittymä label Dec 19, 2025

tomipir added this to KÄYTTÖLIITTYMÄ Dec 19, 2025

BillTheBeast moved this to Tarkistuksessa in KÄYTTÖLIITTYMÄ Dec 22, 2025

BillTheBeast and others added 4 commits January 7, 2026 10:30

Fixed errors in namespace names.

9fae7fe

Reverted changes to UICanvas.

fbd8918

Made funnel smoother

c8cdb73

Changed avatarpart category

0135817

Body part was in hair category

BillTheBeast reviewed Jan 7, 2026

View reviewed changes

Fixed variable names

8717185

BillTheBeast reviewed Jan 7, 2026

View reviewed changes

tomipir added 12 commits January 7, 2026 14:35

Updated ClamController

5453421

-Removed double index calculation -Made while loop more clear to read -Coroutine now stops if you click again before it has finished

Added comments to imply code is in progress

1648934

Updated anchors

f393d86

Made anchors not exceed value 1 or be less than 0

Changed Character anchor offsets to 0

4cb91ee

Updater CategoryGrid

8cb56d8

-Clicking the category cells now selects them in addition to dragging -Bugs out if you go in same direction a few times, need to rethink infinitescroll

Updated clamping

3fe2914

-Buttons now disabled until the animation finishes -Now loops correctly when only clicking buttons

Updated SavePopUp

b3719e7

-Now no longer goes beyond the given screen space

Reordered GridCellHandler arguments

07879f9

Added warning to GridCellHandler

0e24759

-Now shows a warning and does nothing if called without no arguments

Removed unused code

29d3e96

Set functions to private

2336a7b

-Set functions not needed elsewhere private

Split cells to different prefabs

d20c066

-Made own scrips for featurecell, categorycell and colorcell that inherift from gridcellhandler -Made each its own prefab -Adjusted scripts to work with these changes

Updated AvatarEditor #1165

Are you sure you want to change the base?

Updated AvatarEditor #1165

Uh oh!

Conversation

tomipir commented Dec 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants