Skip to content

Commit 07cbd87

Browse files
andy-shevcminyard
authored andcommitted
ipmi_si: Join string literals back
For easy grepping on debug purposes join string literals back in the messages. No functional change. Signed-off-by: Andy Shevchenko <[email protected]> Message-Id: <[email protected]> Signed-off-by: Corey Minyard <[email protected]>
1 parent 25f314d commit 07cbd87

File tree

6 files changed

+38
-66
lines changed

6 files changed

+38
-66
lines changed

drivers/char/ipmi/ipmi_msghandler.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5209,7 +5209,6 @@ module_exit(cleanup_ipmi);
52095209
module_init(ipmi_init_msghandler_mod);
52105210
MODULE_LICENSE("GPL");
52115211
MODULE_AUTHOR("Corey Minyard <[email protected]>");
5212-
MODULE_DESCRIPTION("Incoming and outgoing message routing for an IPMI"
5213-
" interface.");
5212+
MODULE_DESCRIPTION("Incoming and outgoing message routing for an IPMI interface.");
52145213
MODULE_VERSION(IPMI_DRIVER_VERSION);
52155214
MODULE_SOFTDEP("post: ipmi_devintf");

drivers/char/ipmi/ipmi_si_hardcode.c

Lines changed: 16 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -32,47 +32,29 @@ static int slave_addrs[SI_MAX_PARMS] __initdata;
3232
static unsigned int num_slave_addrs __initdata;
3333

3434
module_param_string(type, si_type_str, MAX_SI_TYPE_STR, 0);
35-
MODULE_PARM_DESC(type, "Defines the type of each interface, each"
36-
" interface separated by commas. The types are 'kcs',"
37-
" 'smic', and 'bt'. For example si_type=kcs,bt will set"
38-
" the first interface to kcs and the second to bt");
35+
MODULE_PARM_DESC(type,
36+
"Defines the type of each interface, each interface separated by commas. The types are 'kcs', 'smic', and 'bt'. For example si_type=kcs,bt will set the first interface to kcs and the second to bt");
3937
module_param_hw_array(addrs, ulong, iomem, &num_addrs, 0);
40-
MODULE_PARM_DESC(addrs, "Sets the memory address of each interface, the"
41-
" addresses separated by commas. Only use if an interface"
42-
" is in memory. Otherwise, set it to zero or leave"
43-
" it blank.");
38+
MODULE_PARM_DESC(addrs,
39+
"Sets the memory address of each interface, the addresses separated by commas. Only use if an interface is in memory. Otherwise, set it to zero or leave it blank.");
4440
module_param_hw_array(ports, uint, ioport, &num_ports, 0);
45-
MODULE_PARM_DESC(ports, "Sets the port address of each interface, the"
46-
" addresses separated by commas. Only use if an interface"
47-
" is a port. Otherwise, set it to zero or leave"
48-
" it blank.");
41+
MODULE_PARM_DESC(ports,
42+
"Sets the port address of each interface, the addresses separated by commas. Only use if an interface is a port. Otherwise, set it to zero or leave it blank.");
4943
module_param_hw_array(irqs, int, irq, &num_irqs, 0);
50-
MODULE_PARM_DESC(irqs, "Sets the interrupt of each interface, the"
51-
" addresses separated by commas. Only use if an interface"
52-
" has an interrupt. Otherwise, set it to zero or leave"
53-
" it blank.");
44+
MODULE_PARM_DESC(irqs,
45+
"Sets the interrupt of each interface, the addresses separated by commas. Only use if an interface has an interrupt. Otherwise, set it to zero or leave it blank.");
5446
module_param_hw_array(regspacings, int, other, &num_regspacings, 0);
55-
MODULE_PARM_DESC(regspacings, "The number of bytes between the start address"
56-
" and each successive register used by the interface. For"
57-
" instance, if the start address is 0xca2 and the spacing"
58-
" is 2, then the second address is at 0xca4. Defaults"
59-
" to 1.");
47+
MODULE_PARM_DESC(regspacings,
48+
"The number of bytes between the start address and each successive register used by the interface. For instance, if the start address is 0xca2 and the spacing is 2, then the second address is at 0xca4. Defaults to 1.");
6049
module_param_hw_array(regsizes, int, other, &num_regsizes, 0);
61-
MODULE_PARM_DESC(regsizes, "The size of the specific IPMI register in bytes."
62-
" This should generally be 1, 2, 4, or 8 for an 8-bit,"
63-
" 16-bit, 32-bit, or 64-bit register. Use this if you"
64-
" the 8-bit IPMI register has to be read from a larger"
65-
" register.");
50+
MODULE_PARM_DESC(regsizes,
51+
"The size of the specific IPMI register in bytes. This should generally be 1, 2, 4, or 8 for an 8-bit, 16-bit, 32-bit, or 64-bit register. Use this if you the 8-bit IPMI register has to be read from a larger register.");
6652
module_param_hw_array(regshifts, int, other, &num_regshifts, 0);
67-
MODULE_PARM_DESC(regshifts, "The amount to shift the data read from the."
68-
" IPMI register, in bits. For instance, if the data"
69-
" is read from a 32-bit word and the IPMI data is in"
70-
" bit 8-15, then the shift would be 8");
53+
MODULE_PARM_DESC(regshifts,
54+
"The amount to shift the data read from the. IPMI register, in bits. For instance, if the data is read from a 32-bit word and the IPMI data is in bit 8-15, then the shift would be 8");
7155
module_param_hw_array(slave_addrs, int, other, &num_slave_addrs, 0);
72-
MODULE_PARM_DESC(slave_addrs, "Set the default IPMB slave address for"
73-
" the controller. Normally this is 0x20, but can be"
74-
" overridden by this parm. This is an array indexed"
75-
" by interface number.");
56+
MODULE_PARM_DESC(slave_addrs,
57+
"Set the default IPMB slave address for the controller. Normally this is 0x20, but can be overridden by this parm. This is an array indexed by interface number.");
7658

7759
static void __init ipmi_hardcode_init_one(const char *si_type_str,
7860
unsigned int i,

drivers/char/ipmi/ipmi_si_hotmod.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,8 @@
1717
static int hotmod_handler(const char *val, const struct kernel_param *kp);
1818

1919
module_param_call(hotmod, hotmod_handler, NULL, NULL, 0200);
20-
MODULE_PARM_DESC(hotmod, "Add and remove interfaces. See"
21-
" Documentation/driver-api/ipmi.rst in the kernel sources for the"
22-
" gory details.");
20+
MODULE_PARM_DESC(hotmod,
21+
"Add and remove interfaces. See Documentation/driver-api/ipmi.rst in the kernel sources for the gory details.");
2322

2423
/*
2524
* Parms come in as <op1>[:op2[:op3...]]. ops are:

drivers/char/ipmi/ipmi_si_intf.c

Lines changed: 9 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1170,9 +1170,8 @@ static int smi_start_processing(void *send_info,
11701170
new_smi->thread = kthread_run(ipmi_thread, new_smi,
11711171
"kipmi%d", new_smi->si_num);
11721172
if (IS_ERR(new_smi->thread)) {
1173-
dev_notice(new_smi->io.dev, "Could not start"
1174-
" kernel thread due to error %ld, only using"
1175-
" timers to drive the interface\n",
1173+
dev_notice(new_smi->io.dev,
1174+
"Could not start kernel thread due to error %ld, only using timers to drive the interface\n",
11761175
PTR_ERR(new_smi->thread));
11771176
new_smi->thread = NULL;
11781177
}
@@ -1224,18 +1223,14 @@ static int smi_num; /* Used to sequence the SMIs */
12241223
static const char * const addr_space_to_str[] = { "i/o", "mem" };
12251224

12261225
module_param_array(force_kipmid, int, &num_force_kipmid, 0);
1227-
MODULE_PARM_DESC(force_kipmid, "Force the kipmi daemon to be enabled (1) or"
1228-
" disabled(0). Normally the IPMI driver auto-detects"
1229-
" this, but the value may be overridden by this parm.");
1226+
MODULE_PARM_DESC(force_kipmid,
1227+
"Force the kipmi daemon to be enabled (1) or disabled(0). Normally the IPMI driver auto-detects this, but the value may be overridden by this parm.");
12301228
module_param(unload_when_empty, bool, 0);
1231-
MODULE_PARM_DESC(unload_when_empty, "Unload the module if no interfaces are"
1232-
" specified or found, default is 1. Setting to 0"
1233-
" is useful for hot add of devices using hotmod.");
1229+
MODULE_PARM_DESC(unload_when_empty,
1230+
"Unload the module if no interfaces are specified or found, default is 1. Setting to 0 is useful for hot add of devices using hotmod.");
12341231
module_param_array(kipmid_max_busy_us, uint, &num_max_busy_us, 0644);
12351232
MODULE_PARM_DESC(kipmid_max_busy_us,
1236-
"Max time (in microseconds) to busy-wait for IPMI data before"
1237-
" sleeping. 0 (default) means to wait forever. Set to 100-500"
1238-
" if kipmid is using up a lot of CPU time.");
1233+
"Max time (in microseconds) to busy-wait for IPMI data before sleeping. 0 (default) means to wait forever. Set to 100-500 if kipmid is using up a lot of CPU time.");
12391234

12401235
void ipmi_irq_finish_setup(struct si_sm_io *io)
12411236
{
@@ -1271,8 +1266,7 @@ int ipmi_std_irq_setup(struct si_sm_io *io)
12711266
SI_DEVICE_NAME,
12721267
io->irq_handler_data);
12731268
if (rv) {
1274-
dev_warn(io->dev, "%s unable to claim interrupt %d,"
1275-
" running polled\n",
1269+
dev_warn(io->dev, "%s unable to claim interrupt %d, running polled\n",
12761270
SI_DEVICE_NAME, io->irq);
12771271
io->irq = 0;
12781272
} else {
@@ -2301,5 +2295,4 @@ module_exit(cleanup_ipmi_si);
23012295
MODULE_ALIAS("platform:dmi-ipmi-si");
23022296
MODULE_LICENSE("GPL");
23032297
MODULE_AUTHOR("Corey Minyard <[email protected]>");
2304-
MODULE_DESCRIPTION("Interface to the IPMI driver for the KCS, SMIC, and BT"
2305-
" system interfaces.");
2298+
MODULE_DESCRIPTION("Interface to the IPMI driver for the KCS, SMIC, and BT system interfaces.");

drivers/char/ipmi/ipmi_si_pci.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ static bool pci_registered;
1616
static bool si_trypci = true;
1717

1818
module_param_named(trypci, si_trypci, bool, 0);
19-
MODULE_PARM_DESC(trypci, "Setting this to zero will disable the"
20-
" default scan of the interfaces identified via pci");
19+
MODULE_PARM_DESC(trypci,
20+
"Setting this to zero will disable the default scan of the interfaces identified via pci");
2121

2222
#define PCI_DEVICE_ID_HP_MMC 0x121A
2323

drivers/char/ipmi/ipmi_si_platform.c

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -34,23 +34,22 @@ static bool si_trydmi = false;
3434
#endif
3535

3636
module_param_named(tryplatform, si_tryplatform, bool, 0);
37-
MODULE_PARM_DESC(tryplatform, "Setting this to zero will disable the"
38-
" default scan of the interfaces identified via platform"
39-
" interfaces besides ACPI, OpenFirmware, and DMI");
37+
MODULE_PARM_DESC(tryplatform,
38+
"Setting this to zero will disable the default scan of the interfaces identified via platform interfaces besides ACPI, OpenFirmware, and DMI");
4039
#ifdef CONFIG_ACPI
4140
module_param_named(tryacpi, si_tryacpi, bool, 0);
42-
MODULE_PARM_DESC(tryacpi, "Setting this to zero will disable the"
43-
" default scan of the interfaces identified via ACPI");
41+
MODULE_PARM_DESC(tryacpi,
42+
"Setting this to zero will disable the default scan of the interfaces identified via ACPI");
4443
#endif
4544
#ifdef CONFIG_OF
4645
module_param_named(tryopenfirmware, si_tryopenfirmware, bool, 0);
47-
MODULE_PARM_DESC(tryopenfirmware, "Setting this to zero will disable the"
48-
" default scan of the interfaces identified via OpenFirmware");
46+
MODULE_PARM_DESC(tryopenfirmware,
47+
"Setting this to zero will disable the default scan of the interfaces identified via OpenFirmware");
4948
#endif
5049
#ifdef CONFIG_DMI
5150
module_param_named(trydmi, si_trydmi, bool, 0);
52-
MODULE_PARM_DESC(trydmi, "Setting this to zero will disable the"
53-
" default scan of the interfaces identified via DMI");
51+
MODULE_PARM_DESC(trydmi,
52+
"Setting this to zero will disable the default scan of the interfaces identified via DMI");
5453
#endif
5554

5655
#ifdef CONFIG_ACPI

0 commit comments

Comments
 (0)