Skip to content

Commit 244dba4

Browse files
committed
drm/i915: replace random CNL comments
Cleanup remaining cases that we find CNL in the codebase. Signed-off-by: Lucas De Marchi <[email protected]> Reviewed-by: Rodrigo Vivi <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent a2db194 commit 244dba4

File tree

8 files changed

+10
-12
lines changed

8 files changed

+10
-12
lines changed

drivers/gpu/drm/i915/display/intel_bios.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1998,7 +1998,7 @@ static void parse_ddi_port(struct drm_i915_private *i915,
19981998
"Port %c VBT HDMI boost level: %d\n",
19991999
port_name(port), hdmi_boost_level);
20002000

2001-
/* DP max link rate for CNL+ */
2001+
/* DP max link rate for GLK+ */
20022002
if (i915->vbt.version >= 216) {
20032003
if (i915->vbt.version >= 230)
20042004
info->dp_max_link_rate = parse_bdb_230_dp_max_link_rate(child->dp_max_link_rate);

drivers/gpu/drm/i915/display/intel_display.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3575,7 +3575,7 @@ static void hsw_crtc_enable(struct intel_atomic_state *state,
35753575

35763576
crtc->active = true;
35773577

3578-
/* Display WA #1180: WaDisableScalarClockGating: glk, cnl */
3578+
/* Display WA #1180: WaDisableScalarClockGating: glk */
35793579
psl_clkgate_wa = DISPLAY_VER(dev_priv) == 10 &&
35803580
new_crtc_state->pch_pfit.enabled;
35813581
if (psl_clkgate_wa)
@@ -9870,7 +9870,7 @@ static int intel_atomic_check_async(struct intel_atomic_state *state)
98709870

98719871
/*
98729872
* FIXME: This check is kept generic for all platforms.
9873-
* Need to verify this for all gen9 and gen10 platforms to enable
9873+
* Need to verify this for all gen9 platforms to enable
98749874
* this selectively if required.
98759875
*/
98769876
switch (new_plane_state->hw.fb->modifier) {
@@ -13257,7 +13257,7 @@ get_encoder_power_domains(struct drm_i915_private *dev_priv)
1325713257
static void intel_early_display_was(struct drm_i915_private *dev_priv)
1325813258
{
1325913259
/*
13260-
* Display WA #1185 WaDisableDARBFClkGating:cnl,glk,icl,ehl,tgl
13260+
* Display WA #1185 WaDisableDARBFClkGating:glk,icl,ehl,tgl
1326113261
* Also known as Wa_14010480278.
1326213262
*/
1326313263
if (IS_DISPLAY_VER(dev_priv, 10, 12))

drivers/gpu/drm/i915/display/intel_dp_aux.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,6 @@ static u32 skl_get_aux_send_ctl(struct intel_dp *intel_dp,
158158
/*
159159
* Max timeout values:
160160
* SKL-GLK: 1.6ms
161-
* CNL: 3.2ms
162161
* ICL+: 4ms
163162
*/
164163
ret = DP_AUX_CH_CTL_SEND_BUSY |

drivers/gpu/drm/i915/display/intel_dpll_mgr.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,9 +204,8 @@ struct intel_dpll_hw_state {
204204
/* HDMI only, 0 when used for DP */
205205
u32 cfgcr1, cfgcr2;
206206

207-
/* cnl */
207+
/* icl */
208208
u32 cfgcr0;
209-
/* CNL also uses cfgcr1 */
210209

211210
/* bxt */
212211
u32 ebb0, ebb4, pll0, pll1, pll2, pll3, pll6, pll8, pll9, pll10, pcsdw12;

drivers/gpu/drm/i915/display/intel_gmbus.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -600,7 +600,7 @@ do_gmbus_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs, int num,
600600
int i = 0, inc, try = 0;
601601
int ret = 0;
602602

603-
/* Display WA #0868: skl,bxt,kbl,cfl,glk,cnl */
603+
/* Display WA #0868: skl,bxt,kbl,cfl,glk */
604604
if (IS_GEMINILAKE(dev_priv) || IS_BROXTON(dev_priv))
605605
bxt_gmbus_clock_gating(dev_priv, false);
606606
else if (HAS_PCH_SPT(dev_priv) || HAS_PCH_CNP(dev_priv))
@@ -713,7 +713,7 @@ do_gmbus_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs, int num,
713713
ret = -EAGAIN;
714714

715715
out:
716-
/* Display WA #0868: skl,bxt,kbl,cfl,glk,cnl */
716+
/* Display WA #0868: skl,bxt,kbl,cfl,glk */
717717
if (IS_GEMINILAKE(dev_priv) || IS_BROXTON(dev_priv))
718718
bxt_gmbus_clock_gating(dev_priv, true);
719719
else if (HAS_PCH_SPT(dev_priv) || HAS_PCH_CNP(dev_priv))

drivers/gpu/drm/i915/display/intel_vbt_defs.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -456,7 +456,7 @@ struct child_device_config {
456456
u16 dp_gpio_pin_num; /* 195 */
457457
u8 dp_iboost_level:4; /* 196 */
458458
u8 hdmi_iboost_level:4; /* 196 */
459-
u8 dp_max_link_rate:3; /* 216/230 CNL+ */
459+
u8 dp_max_link_rate:3; /* 216/230 GLK+ */
460460
u8 dp_max_link_rate_reserved:5; /* 216/230 */
461461
} __packed;
462462

drivers/gpu/drm/i915/display/skl_universal_plane.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1270,7 +1270,7 @@ static int skl_plane_check_dst_coordinates(const struct intel_crtc_state *crtc_s
12701270
int pipe_src_w = crtc_state->pipe_src_w;
12711271

12721272
/*
1273-
* Display WA #1175: cnl,glk
1273+
* Display WA #1175: glk
12741274
* Planes other than the cursor may cause FIFO underflow and display
12751275
* corruption if starting less than 4 pixels from the right edge of
12761276
* the screen.

drivers/gpu/drm/i915/intel_device_info.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ enum intel_platform {
105105
#define INTEL_SUBPLATFORM_ULT (0)
106106
#define INTEL_SUBPLATFORM_ULX (1)
107107

108-
/* CNL/ICL */
108+
/* ICL */
109109
#define INTEL_SUBPLATFORM_PORTF (0)
110110

111111
/* DG2 */

0 commit comments

Comments
 (0)