Skip to content

Commit 78f613b

Browse files
committed
drm/i915: finish removal of CNL
With all the users removed, finish removing the CNL platform definitions. We will leave the PCI IDs around as those are exposed to userspace. Even if mesa doesn't support CNL anymore, let's avoid build breakages due to changing the headers. Also, due to drm/i915/gt still using IS_CANNONLAKE() let's just redefine it instead of removing. Signed-off-by: Lucas De Marchi <[email protected]> Reviewed-by: Rodrigo Vivi <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent a4d082f commit 78f613b

File tree

5 files changed

+7
-29
lines changed

5 files changed

+7
-29
lines changed

drivers/gpu/drm/i915/i915_drv.h

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1380,7 +1380,7 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
13801380
#define IS_GEMINILAKE(dev_priv) IS_PLATFORM(dev_priv, INTEL_GEMINILAKE)
13811381
#define IS_COFFEELAKE(dev_priv) IS_PLATFORM(dev_priv, INTEL_COFFEELAKE)
13821382
#define IS_COMETLAKE(dev_priv) IS_PLATFORM(dev_priv, INTEL_COMETLAKE)
1383-
#define IS_CANNONLAKE(dev_priv) IS_PLATFORM(dev_priv, INTEL_CANNONLAKE)
1383+
#define IS_CANNONLAKE(dev_priv) 0
13841384
#define IS_ICELAKE(dev_priv) IS_PLATFORM(dev_priv, INTEL_ICELAKE)
13851385
#define IS_JSL_EHL(dev_priv) (IS_PLATFORM(dev_priv, INTEL_JASPERLAKE) || \
13861386
IS_PLATFORM(dev_priv, INTEL_ELKHARTLAKE))
@@ -1446,8 +1446,6 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
14461446
#define IS_CML_GT2(dev_priv) (IS_COMETLAKE(dev_priv) && \
14471447
INTEL_INFO(dev_priv)->gt == 2)
14481448

1449-
#define IS_CNL_WITH_PORT_F(dev_priv) \
1450-
IS_SUBPLATFORM(dev_priv, INTEL_CANNONLAKE, INTEL_SUBPLATFORM_PORTF)
14511449
#define IS_ICL_WITH_PORT_F(dev_priv) \
14521450
IS_SUBPLATFORM(dev_priv, INTEL_ICELAKE, INTEL_SUBPLATFORM_PORTF)
14531451

@@ -1592,9 +1590,7 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
15921590

15931591
/* WaRsDisableCoarsePowerGating:skl,cnl */
15941592
#define NEEDS_WaRsDisableCoarsePowerGating(dev_priv) \
1595-
(IS_CANNONLAKE(dev_priv) || \
1596-
IS_SKL_GT3(dev_priv) || \
1597-
IS_SKL_GT4(dev_priv))
1593+
(IS_SKL_GT3(dev_priv) || IS_SKL_GT4(dev_priv))
15981594

15991595
#define HAS_GMBUS_IRQ(dev_priv) (GRAPHICS_VER(dev_priv) >= 4)
16001596
#define HAS_GMBUS_BURST_READ(dev_priv) (GRAPHICS_VER(dev_priv) >= 11 || \

drivers/gpu/drm/i915/i915_pci.c

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -787,27 +787,13 @@ static const struct intel_device_info cml_gt2_info = {
787787
.gt = 2,
788788
};
789789

790-
#define GEN10_FEATURES \
791-
GEN9_FEATURES, \
792-
GEN(10), \
793-
.dbuf.size = 1024 - 4, /* 4 blocks for bypass path allocation */ \
794-
.display.has_dsc = 1, \
795-
.has_coherent_ggtt = false, \
796-
GLK_COLORS
797-
798-
static const struct intel_device_info cnl_info = {
799-
GEN10_FEATURES,
800-
PLATFORM(INTEL_CANNONLAKE),
801-
.gt = 2,
802-
};
803-
804790
#define GEN11_DEFAULT_PAGE_SIZES \
805791
.page_sizes = I915_GTT_PAGE_SIZE_4K | \
806792
I915_GTT_PAGE_SIZE_64K | \
807793
I915_GTT_PAGE_SIZE_2M
808794

809795
#define GEN11_FEATURES \
810-
GEN10_FEATURES, \
796+
GEN9_FEATURES, \
811797
GEN11_DEFAULT_PAGE_SIZES, \
812798
.abox_mask = BIT(0), \
813799
.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | \
@@ -830,10 +816,12 @@ static const struct intel_device_info cnl_info = {
830816
[TRANSCODER_DSI_1] = TRANSCODER_DSI1_OFFSET, \
831817
}, \
832818
GEN(11), \
819+
.color = { .degamma_lut_size = 33, .gamma_lut_size = 262145 }, \
833820
.dbuf.size = 2048, \
834821
.dbuf.slice_mask = BIT(DBUF_S1) | BIT(DBUF_S2), \
835-
.has_logical_ring_elsq = 1, \
836-
.color = { .degamma_lut_size = 33, .gamma_lut_size = 262145 }
822+
.display.has_dsc = 1, \
823+
.has_coherent_ggtt = false, \
824+
.has_logical_ring_elsq = 1
837825

838826
static const struct intel_device_info icl_info = {
839827
GEN11_FEATURES,
@@ -1123,7 +1111,6 @@ static const struct pci_device_id pciidlist[] = {
11231111
INTEL_CML_GT2_IDS(&cml_gt2_info),
11241112
INTEL_CML_U_GT1_IDS(&cml_gt1_info),
11251113
INTEL_CML_U_GT2_IDS(&cml_gt2_info),
1126-
INTEL_CNL_IDS(&cnl_info),
11271114
INTEL_ICL_11_IDS(&icl_info),
11281115
INTEL_EHL_IDS(&ehl_info),
11291116
INTEL_JSL_IDS(&jsl_info),

drivers/gpu/drm/i915/i915_perf.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4309,7 +4309,6 @@ static void oa_init_supported_formats(struct i915_perf *perf)
43094309
case INTEL_GEMINILAKE:
43104310
case INTEL_COFFEELAKE:
43114311
case INTEL_COMETLAKE:
4312-
case INTEL_CANNONLAKE:
43134312
case INTEL_ICELAKE:
43144313
case INTEL_ELKHARTLAKE:
43154314
case INTEL_JASPERLAKE:

drivers/gpu/drm/i915/intel_device_info.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ static const char * const platform_names[] = {
5959
PLATFORM_NAME(GEMINILAKE),
6060
PLATFORM_NAME(COFFEELAKE),
6161
PLATFORM_NAME(COMETLAKE),
62-
PLATFORM_NAME(CANNONLAKE),
6362
PLATFORM_NAME(ICELAKE),
6463
PLATFORM_NAME(ELKHARTLAKE),
6564
PLATFORM_NAME(JASPERLAKE),
@@ -175,7 +174,6 @@ static const u16 subplatform_ulx_ids[] = {
175174
};
176175

177176
static const u16 subplatform_portf_ids[] = {
178-
INTEL_CNL_PORT_F_IDS(0),
179177
INTEL_ICL_PORT_F_IDS(0),
180178
};
181179

drivers/gpu/drm/i915/intel_device_info.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,6 @@ enum intel_platform {
7676
INTEL_GEMINILAKE,
7777
INTEL_COFFEELAKE,
7878
INTEL_COMETLAKE,
79-
/* gen10 */
80-
INTEL_CANNONLAKE,
8179
/* gen11 */
8280
INTEL_ICELAKE,
8381
INTEL_ELKHARTLAKE,

0 commit comments

Comments
 (0)