Skip to content

Commit 82929a2

Browse files
committed
drm/i915: Correct SFC_DONE register offset
The register offset for SFC_DONE was missing a '0' at the end, causing us to read from a non-existent register address. We only use this register in error state dumps so the mistake hasn't caused any real problems, but fixing it will hopefully make the error state dumps a bit more useful for debugging. Fixes: e50dbdb ("drm/i915/tgl: Add SFC instdone to error state") Cc: Mika Kuoppala <[email protected]> Signed-off-by: Matt Roper <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] Reviewed-by: Mika Kuoppala <[email protected]>
1 parent 615a772 commit 82929a2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/i915/i915_reg.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,7 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)
422422
#define GEN12_HCP_SFC_LOCK_ACK_BIT REG_BIT(1)
423423
#define GEN12_HCP_SFC_USAGE_BIT REG_BIT(0)
424424

425-
#define GEN12_SFC_DONE(n) _MMIO(0x1cc00 + (n) * 0x100)
425+
#define GEN12_SFC_DONE(n) _MMIO(0x1cc000 + (n) * 0x1000)
426426
#define GEN12_SFC_DONE_MAX 4
427427

428428
#define RING_PP_DIR_BASE(base) _MMIO((base) + 0x228)

0 commit comments

Comments
 (0)