Skip to content

Commit d2d106f

Browse files
lztogregkh
authored andcommitted
staging: comedi: cb_pcidas64: fix request_irq() warn
request_irq() wont accept a name which contains slash so we need to repalce it with something else -- otherwise it will trigger a warning and the entry in /proc/irq/ will not be created since the .name might be used by userspace and we don't want to break userspace, so we are changing the parameters passed to request_irq() [ 1.565966] name 'pci-das6402/16' [ 1.566149] WARNING: CPU: 0 PID: 184 at fs/proc/generic.c:180 __xlate_proc_name+0x93/0xb0 [ 1.568923] RIP: 0010:__xlate_proc_name+0x93/0xb0 [ 1.574200] Call Trace: [ 1.574722] proc_mkdir+0x18/0x20 [ 1.576629] request_threaded_irq+0xfe/0x160 [ 1.576859] auto_attach+0x60a/0xc40 [cb_pcidas64] Suggested-by: Ian Abbott <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Tong Zhang <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 2e5848a commit d2d106f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/staging/comedi/drivers/cb_pcidas64.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4035,7 +4035,7 @@ static int auto_attach(struct comedi_device *dev,
40354035
init_stc_registers(dev);
40364036

40374037
retval = request_irq(pcidev->irq, handle_interrupt, IRQF_SHARED,
4038-
dev->board_name, dev);
4038+
"cb_pcidas64", dev);
40394039
if (retval) {
40404040
dev_dbg(dev->class_dev, "unable to allocate irq %u\n",
40414041
pcidev->irq);

0 commit comments

Comments
 (0)