Refactor: Standardize insight NAME attributes to snake_case identifiers

Update NAME attributes across all insight classes from verbose descriptions
to concise snake_case identifiers for better programmatic usage. This change
affects 54 files across checks, tests, governance, modelling, performance,
SQL, and structure insights.

Key changes:
- Check insights: Use descriptive snake_case (e.g., column_name_inconsistent_desc)
- Test insights: Standardize naming (e.g., missing_primary_keys_tests)
- Governance insights: Clarify purpose (e.g., public_model_no_contract)
- Modelling insights: Simplify names (e.g., direct_join_to_source)
- Performance insights: Concise identifiers (e.g., chain_view_linking)
- Structure insights: Pattern-based naming (e.g., model_path_violation)

Also fixes typo in check_model_name_contract.py ("Mmdel" -> proper identifier)

ALIAS and DESCRIPTION fields remain unchanged for backward compatibility
and human-readable documentation.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: mdesmet

src/datapilot/core/platforms/dbt/insights/checks/check_column_desc_are_same.py

@@ -9,7 +9,7 @@
 
 
 class CheckColumnDescAreSame(ChecksInsight):
-    NAME = "Column descriptions consistent for same column names"
+    NAME = "column_name_inconsistent_desc"
     ALIAS = "column_descriptions_are_same"
     DESCRIPTION = "Column description for the same column name should be same "
     REASON_TO_FLAG = (

src/datapilot/core/platforms/dbt/insights/checks/check_column_name_contract.py

@@ -14,7 +14,7 @@
 
 
 class CheckColumnNameContract(ChecksInsight):
-    NAME = "Column name follows contract pattern"
+    NAME = "column_name_pattern_violation"
     ALIAS = "column_name_contract"
     DESCRIPTION = "Column names should adhere to the contract pattern defined for the data type. "
     REASON_TO_FLAG = (

src/datapilot/core/platforms/dbt/insights/checks/check_macro_args_have_desc.py

@@ -8,7 +8,7 @@
 
 
 class CheckMacroArgsHaveDesc(ChecksInsight):
-    NAME = "Check macro arguments has description"
+    NAME = "macro_arg_no_desc"
     ALIAS = "check_macro_args_have_desc"
     DESCRIPTION = "Macro arguments should have a description. "
     REASON_TO_FLAG = "Clear descriptions for macro arguments are crucial as they prevent misunderstandings, enhance user comprehension, and simplify maintenance. This leads to more accurate data analysis and efficient workflows."

src/datapilot/core/platforms/dbt/insights/checks/check_macro_has_desc.py

@@ -8,7 +8,7 @@
 
 
 class CheckMacroHasDesc(ChecksInsight):
-    NAME = "Macro has documentation"
+    NAME = "macro_no_docs"
     ALIAS = "check_macro_has_desc"
     DESCRIPTION = "Macros should be documented."
     REASON_TO_FLAG = "Undocumented macros can cause misunderstandings and inefficiencies in data modeling and analysis, as they make it difficult to understand their purpose and usage. Clear descriptions are vital for accuracy and streamlined workflow."

src/datapilot/core/platforms/dbt/insights/checks/check_model_has_all_columns.py

@@ -14,7 +14,7 @@
 
 
 class CheckModelHasAllColumns(ChecksInsight):
-    NAME = "Model has all columns as per catalog"
+    NAME = "model_missing_columns"
     ALIAS = "check_model_has_all_columns"
     DESCRIPTION = "Models should have all the columns as per the catalog."
     REASON_TO_FLAG = (

src/datapilot/core/platforms/dbt/insights/checks/check_model_has_meta_keys.py

@@ -12,7 +12,7 @@
 
 
 class CheckModelHasMetaKeys(ChecksInsight):
-    NAME = "Model has all valid keys in metadata"
+    NAME = "model_invalid_meta_keys"
     ALIAS = "check_model_has_valid_meta_keys"
     DESCRIPTION = "Model always has a list of valid metadata keys."
     REASON_TO_FLAG = (

src/datapilot/core/platforms/dbt/insights/checks/check_model_has_properties_file.py

@@ -8,7 +8,7 @@
 
 
 class CheckModelHasPropertiesFile(ChecksInsight):
-    NAME = "Model has properties file"
+    NAME = "model_no_schema_file"
     ALIAS = "check_model_has_properties_file"
     DESCRIPTION = "Models should have a properties/schema file (.yml) defined."
     REASON_TO_FLAG = (

src/datapilot/core/platforms/dbt/insights/checks/check_model_has_tests_by_group.py

@@ -9,7 +9,7 @@
 
 
 class CheckModelHasTestsByGroup(ChecksInsight):
-    NAME = "Model has tests by group"
+    NAME = "model_insufficient_tests_by_group"
     ALIAS = "check_model_has_tests_by_group"
     DESCRIPTION = "Check if models have a number of tests for specific test groups."
     REASON_TO_FLAG = "Models should have tests with specific groups for proper validation."

src/datapilot/core/platforms/dbt/insights/checks/check_model_has_tests_by_name.py

@@ -9,7 +9,7 @@
 
 
 class CheckModelHasTestsByName(ChecksInsight):
-    NAME = "Model has tests by name"
+    NAME = "model_missing_required_tests"
     ALIAS = "check_model_has_tests_by_name"
     DESCRIPTION = "Checks that the model has tests with specific names."
     REASON_TO_FLAG = "Models should have tests with specific names for proper validation."

src/datapilot/core/platforms/dbt/insights/checks/check_model_has_tests_by_type.py

@@ -9,7 +9,7 @@
 
 
 class CheckModelHasTestsByType(ChecksInsight):
-    NAME = "Model has tests by type"
+    NAME = "model_insufficient_tests_by_type"
     ALIAS = "check_model_has_tests_by_type"
     DESCRIPTION = "Checks that the model has tests with specific types."
     REASON_TO_FLAG = "Models should have tests with specific types for proper validation."