-
Notifications
You must be signed in to change notification settings - Fork 1
feat: support .altimate config #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed everything up to e9d3f71 in 1 minute and 48 seconds. Click for details.
- Reviewed
203lines of code in3files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. setup.py:72
- Draft comment:
Good: 'python-dotenv~=1.0.0' dependency added. Ensure the pinned version meets your feature/security requirements. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. src/datapilot/cli/main.py:59
- Draft comment:
load_dotenv() is invoked on each CLI call. Consider centralizing its call (if appropriate) or document that repeated loads are intentional. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. src/datapilot/cli/main.py:29
- Draft comment:
The substitute_env_vars regex leaves unchanged any pattern when an env variable is missing. Confirm that this behavior is desired. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_EFo8nZjgaQ8I0vBM
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed ff3dca6 in 30 seconds. Click for details.
- Reviewed
215lines of code in3files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/datapilot/cli/main.py:21
- Draft comment:
Consider explicitly specifying the read mode (e.g., 'r') when opening the config file for clarity, even though it defaults to read mode. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. tests/core/platform/dbt/test_cli.py:21
- Draft comment:
Test assertions rely on a static string ('-----------') in output, which could be brittle if display formatting changes. Consider asserting on more stable output markers. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_7j1YdxQcLNc7jsmg
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed c4059c7 in 1 minute and 5 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_2RaMToZaIRgUxtWD
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed e5eaab4 in 1 minute and 10 seconds. Click for details.
- Reviewed
54lines of code in1files - Skipped
0files when reviewing. - Skipped posting
6draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. tests/core/platform/dbt/test_cli.py:15
- Draft comment:
Updated CLI invocation to include the 'dbt' subcommand. Ensure documentation and help text are updated accordingly. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. tests/core/platform/dbt/test_cli.py:32
- Draft comment:
Inserted 'dbt' before 'project-health' to reflect new CLI structure. Verify consistency in usage. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. tests/core/platform/dbt/test_cli.py:52
- Draft comment:
Added 'dbt' subcommand in test invocation; ensure this matches the new CLI grouping. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4. tests/core/platform/dbt/test_cli.py:69
- Draft comment:
Prefixed command with 'dbt' to match the refactored CLI structure in macro args test. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
5. tests/core/platform/dbt/test_cli.py:86
- Draft comment:
Added 'dbt' subcommand in the second macro args test invocation; confirm alignment with CLI changes. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
6. tests/core/platform/dbt/test_cli.py:109
- Draft comment:
Updated invocation in v12 test to include 'dbt' as subcommand. Ensure all related docs/tests reflect this change. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_xXIJLu8wRY5PSau1
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed a23748f in 24 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/datapilot/cli/main.py:21
- Draft comment:
Good change: using config_path.open() is the correct way to open the file on a Path object. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_1Wb9aPlOxXfXuhMn
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
suryaiyer95
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. As long as project governance and onboard is tested
Important
Refactor CLI to move common options to top-level command and update tests accordingly.
--token,--instance-name, and--backend-urloptions to top-leveldatapilotcommand inmain.py.~/.altimate/altimate.jsonand.envfile, with CLI args taking precedence.ctx.objto store and pass common options to subcommands.--token,--instance-name, and--backend-urlfromproject-healthandonboardcommands incli.py.ctx.parent.obj.tokenandinstance-nameinonboardif not provided.python-dotenv~=1.0.0toinstall_requiresinsetup.py.test_cli.pyto invokedatapilotwith subcommands, reflecting CLI refactor.This description was created by
for a23748f. You can customize this summary. It will automatically update as commits are pushed.