Skip to content

Conversation

@mdesmet
Copy link
Collaborator

@mdesmet mdesmet commented Jun 10, 2025

Important

Refactor CLI to move common options to top-level command and update tests accordingly.

  • CLI Refactor:
    • Move --token, --instance-name, and --backend-url options to top-level datapilot command in main.py.
    • Load configuration from ~/.altimate/altimate.json and .env file, with CLI args taking precedence.
    • Use ctx.obj to store and pass common options to subcommands.
  • DBT Commands:
    • Remove --token, --instance-name, and --backend-url from project-health and onboard commands in cli.py.
    • Retrieve these options from ctx.parent.obj.
    • Prompt for token and instance-name in onboard if not provided.
  • Dependencies:
    • Add python-dotenv~=1.0.0 to install_requires in setup.py.
  • Tests:
    • Update test_cli.py to invoke datapilot with subcommands, reflecting CLI refactor.

This description was created by Ellipsis for a23748f. You can customize this summary. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to e9d3f71 in 1 minute and 48 seconds. Click for details.
  • Reviewed 203 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. setup.py:72
  • Draft comment:
    Good: 'python-dotenv~=1.0.0' dependency added. Ensure the pinned version meets your feature/security requirements.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. src/datapilot/cli/main.py:59
  • Draft comment:
    load_dotenv() is invoked on each CLI call. Consider centralizing its call (if appropriate) or document that repeated loads are intentional.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
3. src/datapilot/cli/main.py:29
  • Draft comment:
    The substitute_env_vars regex leaves unchanged any pattern when an env variable is missing. Confirm that this behavior is desired.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_EFo8nZjgaQ8I0vBM

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed ff3dca6 in 30 seconds. Click for details.
  • Reviewed 215 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/datapilot/cli/main.py:21
  • Draft comment:
    Consider explicitly specifying the read mode (e.g., 'r') when opening the config file for clarity, even though it defaults to read mode.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
2. tests/core/platform/dbt/test_cli.py:21
  • Draft comment:
    Test assertions rely on a static string ('-----------') in output, which could be brittle if display formatting changes. Consider asserting on more stable output markers.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_7j1YdxQcLNc7jsmg

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed c4059c7 in 1 minute and 5 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

Workflow ID: wflow_2RaMToZaIRgUxtWD

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed e5eaab4 in 1 minute and 10 seconds. Click for details.
  • Reviewed 54 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 6 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. tests/core/platform/dbt/test_cli.py:15
  • Draft comment:
    Updated CLI invocation to include the 'dbt' subcommand. Ensure documentation and help text are updated accordingly.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. tests/core/platform/dbt/test_cli.py:32
  • Draft comment:
    Inserted 'dbt' before 'project-health' to reflect new CLI structure. Verify consistency in usage.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
3. tests/core/platform/dbt/test_cli.py:52
  • Draft comment:
    Added 'dbt' subcommand in test invocation; ensure this matches the new CLI grouping.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
4. tests/core/platform/dbt/test_cli.py:69
  • Draft comment:
    Prefixed command with 'dbt' to match the refactored CLI structure in macro args test.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
5. tests/core/platform/dbt/test_cli.py:86
  • Draft comment:
    Added 'dbt' subcommand in the second macro args test invocation; confirm alignment with CLI changes.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
6. tests/core/platform/dbt/test_cli.py:109
  • Draft comment:
    Updated invocation in v12 test to include 'dbt' as subcommand. Ensure all related docs/tests reflect this change.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_xXIJLu8wRY5PSau1

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed a23748f in 24 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/datapilot/cli/main.py:21
  • Draft comment:
    Good change: using config_path.open() is the correct way to open the file on a Path object.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_1Wb9aPlOxXfXuhMn

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@mdesmet mdesmet changed the title refactor: move token and instance-name to top-level command feat: support .altimate config Jun 10, 2025
Copy link
Collaborator

@suryaiyer95 suryaiyer95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. As long as project governance and onboard is tested

@mdesmet mdesmet merged commit beb191e into main Jun 11, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants