Skip to content

Conversation

@mdesmet
Copy link
Collaborator

@mdesmet mdesmet commented Oct 5, 2025

Important

Add functions field to Disabled7 class in manifest_v12.py to support user-defined functions.

  • Models:
    • Add functions: Optional[list[str]] to Disabled7 class in manifest_v12.py to support user-defined functions.

This description was created by Ellipsis for d6e4126. You can customize this summary. It will automatically update as commits are pushed.

@mdesmet mdesmet requested a review from suryaiyer95 October 5, 2025 13:55
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to d6e4126 in 48 seconds. Click for details.
  • Reviewed 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/vendor/dbt_artifacts_parser/parsers/manifest/manifest_v12.py:4435
  • Draft comment:
    New field functions added. Consider using a more specific type than dict[str, Any] and adding a title/description for consistency with other collections.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_OAMJvjOKNbPWGs6r

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@mdesmet mdesmet merged commit 5888ccb into main Oct 6, 2025
39 checks passed
@mdesmet mdesmet deleted the fix/snapshot-spec branch October 6, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants